Skip to content

Code view component#1285

Merged
epatters merged 5 commits into
mainfrom
cm/component-code-view
May 20, 2026
Merged

Code view component#1285
epatters merged 5 commits into
mainfrom
cm/component-code-view

Conversation

@quffaro
Copy link
Copy Markdown
Collaborator

@quffaro quffaro commented May 19, 2026

Replaces #1252.

@quffaro quffaro added enhancement New feature or request frontend TypeScript frontend and Rust-wasm integrations labels May 19, 2026
@quffaro quffaro force-pushed the cm/component-code-view branch 2 times, most recently from 76d50bf to 40caff0 Compare May 19, 2026 16:49
@quffaro quffaro marked this pull request as ready for review May 19, 2026 16:51
@quffaro quffaro requested a review from kasbah as a code owner May 19, 2026 16:51
@quffaro quffaro marked this pull request as draft May 19, 2026 16:51
@kasbah kasbah force-pushed the cm/component-code-view branch from 40caff0 to 35684f6 Compare May 19, 2026 17:39
@quffaro quffaro marked this pull request as ready for review May 19, 2026 17:56
@quffaro quffaro requested a review from jmoggr as a code owner May 19, 2026 17:56
Copy link
Copy Markdown
Member

@kasbah kasbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mat, looks much cleaner than the Prismjs version!

Comment thread packages/ui-components/src/code_view.tsx Outdated
Comment thread packages/frontend/src/stdlib/analyses/sql.tsx Outdated
@epatters epatters changed the title Code View Component Code view component May 19, 2026
Comment thread packages/ui-components/src/code_view.tsx Outdated
@quffaro quffaro force-pushed the cm/component-code-view branch from 35684f6 to a186a31 Compare May 19, 2026 21:50
Copy link
Copy Markdown
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both! Looks nice and clean.

@epatters epatters merged commit 1685bab into main May 20, 2026
17 checks passed
@epatters epatters deleted the cm/component-code-view branch May 20, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend TypeScript frontend and Rust-wasm integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants