Fix FontAwesome path#136
Open
alejandroandreu wants to merge 1 commit intoTolgaTatli:masterfrom
alejandroandreu:fix-fontawesome-path
Open
Fix FontAwesome path#136alejandroandreu wants to merge 1 commit intoTolgaTatli:masterfrom alejandroandreu:fix-fontawesome-path
alejandroandreu wants to merge 1 commit intoTolgaTatli:masterfrom
alejandroandreu:fix-fontawesome-path
Conversation
$fa-font-path ends has a trailing slash, which that browsers will do requests towards /assets/fonts/FontAwesome//fontawesome-webfont.{eot,woff,ttf} as per _sass/vendor/font-awesome/_path.scss .
For most of modern web servers it's fine, as they will flatten more than 1 forward slash to 1. That is: a//b -> a/b ... However this is not the case when hosting the page in a Amazon AWS S3 bucket, as it interprets it as a literal path that doesn't exist.
Removing the trailing slash from $fa-font-path solves the issue.
See: https://forums.aws.amazon.com/thread.jspa?threadID=13898
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$fa-font-path ends has a trailing slash, which that browsers will do requests towards /assets/fonts/FontAwesome//fontawesome-webfont.{eot,woff,ttf} as per _sass/vendor/font-awesome/_path.scss .
For most of modern web servers it's fine, as they will flatten more than 1 forward slash to 1. That is: a//b -> a/b ... However this is not the case when hosting the page in a Amazon AWS S3 bucket, as it interprets it as a literal path that doesn't exist.
Removing the trailing slash from $fa-font-path solves the issue.
See: https://forums.aws.amazon.com/thread.jspa?threadID=13898