ci: mobile light path-filter + backend perf/leak dispatch#1345
Conversation
- PR path filter mobile → typecheck+unit (frontend-mobile-light) - Keep full mobile suite workflow_dispatch-only - Wire verify-backend-perf-leak-gates.ps1 as dispatch-only job (T5) - Update verify-ci-gates.ps1 policy
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe workflow adds path-filtered mobile light CI for typechecking and unit tests, introduces a manually triggered backend perf/leak gate, and extends CI policy verification and project documentation for both paths. ChangesCI gate coverage
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant PathsFilter
participant FrontendMobileLight
GitHubActions->>PathsFilter: Evaluate mobile path rules
PathsFilter->>FrontendMobileLight: Set mobile change output
FrontendMobileLight->>FrontendMobileLight: Run typecheck and unit tests
sequenceDiagram
participant GitHubActions
participant GoSetup
participant PerfLeakVerifier
GitHubActions->>GoSetup: Set up Go and cached modules
GoSetup->>PerfLeakVerifier: Run backend perf/leak verification
PerfLeakVerifier-->>GitHubActions: Return gate result
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/checks.yml (1)
1-1: 🔒 Security & Privacy | 🔵 Trivial | 💤 Low valueSet
persist-credentials: falsein checkout steps.To follow security best practices and prevent potential credential persistence in the local git configuration (which could be exposed if artifacts were ever uploaded), it is recommended to disable credential persistence for the checkout action when not actively pushing to the repository.
.github/workflows/checks.yml#L460-460: addwith: persist-credentials: falseto theactions/checkout@v4step infrontend-mobile-light..github/workflows/checks.yml#L654-654: addwith: persist-credentials: falseto theactions/checkout@v4step inbackend-perf-leak-gates.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/checks.yml at line 1, Update the actions/checkout@v4 steps in the frontend-mobile-light and backend-perf-leak-gates jobs to include with.persist-credentials set to false, preserving their existing checkout configuration and indentation.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/checks.yml:
- Line 1: Update the actions/checkout@v4 steps in the frontend-mobile-light and
backend-perf-leak-gates jobs to include with.persist-credentials set to false,
preserving their existing checkout configuration and indentation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ec027608-8986-456a-9e12-b473c4d3b568
📒 Files selected for processing (5)
.github/workflows/checks.ymldocs/analysis/post-polish-risk-assessment.mddocs/progress/MASTER.mddocs/roadmap.mdscripts/verify/verify-ci-gates.ps1
Summary
Post-residual CI hardening (closes #1341 blind spot + residual T5):
Mobile light (PR path-filtered)
changes.mobilepaths:app/mobile-rn/**, sharedhubClient*/hubEvents*, lockfile, checks.ymlfrontend-mobile-light: typecheck + unit tests only (≤15m)frontend-mobile(Expo export / Playwright / doctor) remains workflow_dispatch-only for cost controlBackend perf/leak (T5)
backend-perf-leak-gatesjob:verify-backend-perf-leak-gates.ps1 -Benchtime 100msPolicy
scripts/verify/verify-ci-gates.ps1asserts both new jobsVerify
pwsh ./scripts/verify/verify-ci-gates.ps1→ okpwsh ./scripts/verify/verify-doc-ssot.ps1→ okDocs
Summary by CodeRabbit
CI Improvements
Documentation
Validation