Skip to content

join: reshape JoinTactic to an iterator of output containers #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankmcsherry merged 5 commits into from
Jul 8, 2026
Merged

join: reshape JoinTactic to an iterator of output containers #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc495df
join: reshape JoinTactic to an iterator of output containers
frankmcsherry Jul 8, 2026
c80c454
join: remove the now-vestigial EffortBuilder
frankmcsherry Jul 8, 2026
449d2a4
join: fix the columnar example's join sink caller
frankmcsherry Jul 8, 2026
318530a
Tidy some structure
frankmcsherry Jul 8, 2026
ee68e79
join: parameterize JoinTactic by its output container, not the builder
frankmcsherry Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion differential-dataflow/examples/columnar/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ fn main() {
/// Push on UpdatesTyped for the reduce builder path.
mod reachability {

use timely::container::PushInto;
use timely::order::Product;
use differential_dataflow::Collection;
use differential_dataflow::AsCollection;
Expand Down Expand Up @@ -149,7 +150,7 @@ mod reachability {
use differential_dataflow::difference::Multiply;
let dst: Node = *dst;
let diff: Diff = d1.clone().multiply(d2);
session.give::<(Node, (), IterTime, Diff)>((dst, (), time.clone(), diff));
session.push_into((dst, (), time.clone(), diff));
},
).as_collection();

Expand Down
2 changes: 1 addition & 1 deletion differential-dataflow/src/operators/arrange/arrangement.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@
while let Some(key) = cursor.get_key(batch) {
while let Some(val) = cursor.get_val(batch) {
for datum in logic(key, val) {
cursor.map_times(batch, |time, diff| {

Check warning on line 208 in differential-dataflow/src/operators/arrange/arrangement.rs

View workflow job for this annotation

GitHub Actions / Cargo clippy 

`time` shadows a previous, unrelated binding
session.give((datum.clone(), <BatchCursor<Tr> as Cursor>::owned_time(time), <BatchCursor<Tr> as Cursor>::owned_diff(diff)));
});
}
Expand Down Expand Up @@ -251,7 +251,7 @@
other,
move |k, v1, v2, t, d1, d2, c| {
for datum in result(k, v1, v2, t, d1, d2) {
c.give(datum);
c.push_into(datum);
}
}
)
Expand Down
Loading
Loading