Remove SizableContainer requirement from InternalMerge#738
Closed
antiguru wants to merge 1 commit intoTimelyDataflow:master-nextfrom
Closed
Remove SizableContainer requirement from InternalMerge#738antiguru wants to merge 1 commit intoTimelyDataflow:master-nextfrom
antiguru wants to merge 1 commit intoTimelyDataflow:master-nextfrom
Conversation
InternalMerge doesn't require SizableContainer, only some of its implementations do. Instead, we push the requirement where it's used. This allows us to build a columnar-based merge batcher without a SizableContainer implementation. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
5 tasks
Member
|
Can merge, but it would be good to hear about any |
Member
Author
|
If it's going away, then let's just close. This was in reaction to something in another PR. |
Member
|
Deletion performed in #740. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InternalMerge doesn't require SizableContainer, only some of its implementations do. Instead, we push the requirement where it's used. This allows us to build a columnar-based merge batcher without a SizableContainer implementation.