Columnar tidy#694
Merged
frankmcsherry merged 3 commits intoTimelyDataflow:master-nextfrom Mar 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes key specializations to force us to get better at these (and ease development). Also pivots to using
Updatesas the container type, which hybridizes sorted and unsorted representations.This introduces some TODOs, mostly around sorting out the strict requirements for
Accountableand merging. For example, the merger would like consolidated data coming in, but the code deals with zeros by pushing an empty diff list. Is that a problem, and who has to solve it? The accountable type at the moment doesn't distinguish between consolidated/not, and there is the risk of defect if one just picks this up and uses it casually, e.g. without re-consolidating somewhere.