Skip to content

fix: harden snapshot validation and spice handling#30

Merged
TimInTech merged 1 commit into
mainfrom
fix/snapshot-name-validation
Jun 27, 2026
Merged

fix: harden snapshot validation and spice handling#30
TimInTech merged 1 commit into
mainfrom
fix/snapshot-name-validation

Conversation

@TimInTech

Copy link
Copy Markdown
Owner

Summary

  • align snapshot name validation with Proxmox rules
  • use the actual SPICE bind host/port and improve non-GUI fallback
  • extend shell mocks/tests for the new validation and SPICE behavior

Verification

  • local ad-hoc verification for snapshot validation and SPICE fallback
  • remote ad-hoc verification on the Proxmox host for live console/SPICE behavior

@TimInTech TimInTech merged commit dd621a4 into main Jun 27, 2026
5 checks passed
@TimInTech TimInTech deleted the fix/snapshot-name-validation branch June 27, 2026 22:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ba97601df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread proxmox-manager.sh
host="${host#[}"
port="${endpoint##*:}"
elif [[ "$endpoint" == *:* ]]; then
host="${endpoint%:*}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace wildcard SPICE binds before generating .vv

When QEMU reports a wildcard bind such as address: *:5900, address: :::5900, or 0.0.0.0:5900 for SPICE listening on all interfaces, this assignment stores that bind address as the client host and prevents the fallback at line 1322 from choosing the LAN/override address. The generated URI and .vv then contain host=*, host=::, or host=0.0.0.0, which are bind addresses rather than connectable client targets, so SPICE launch breaks for all-interface binds; normalize wildcard hosts to PROXMOX_MANAGER_SPICE_ADDR/hostname -I while keeping the parsed port.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant