fix: harden snapshot validation and spice handling#30
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ba97601df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| host="${host#[}" | ||
| port="${endpoint##*:}" | ||
| elif [[ "$endpoint" == *:* ]]; then | ||
| host="${endpoint%:*}" |
There was a problem hiding this comment.
Replace wildcard SPICE binds before generating .vv
When QEMU reports a wildcard bind such as address: *:5900, address: :::5900, or 0.0.0.0:5900 for SPICE listening on all interfaces, this assignment stores that bind address as the client host and prevents the fallback at line 1322 from choosing the LAN/override address. The generated URI and .vv then contain host=*, host=::, or host=0.0.0.0, which are bind addresses rather than connectable client targets, so SPICE launch breaks for all-interface binds; normalize wildcard hosts to PROXMOX_MANAGER_SPICE_ADDR/hostname -I while keeping the parsed port.
Useful? React with 👍 / 👎.
Summary
Verification