Log WebView render errors in MarkdownRenderer#23
Open
jim-daf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
What this does
Adds an
onReceivedError(view, request, error)override to theWebViewClientinapp/src/main/java/ch/tiim/markdown_widget/MarkdownRenderer.kt. The override logs the error code, description and failing URL throughLog.w(TAG, ...), and is filtered to main-frame requests so that off-host subresources referenced inside rendered markdown do not flood logcat.No behavior change in the happy path, no new dependencies.
Why
onPageFinishedfires regardless of whether the render succeeded. The bitmap then gets drawn from a partially loaded WebView and the widget surface shows a blank or half-rendered tile with nothing in logcat. With this hook in place there is at least a concrete error code and failing URL to look at when a tile renders empty.API level note
The new API 23+
(WebView, WebResourceRequest, WebResourceError)signature is used because the module'sminSdkis 24.