Open
Conversation
Fixes #433 by replacing old codelist declarations with new ones. Closed codelists should be declared with the `enum` keyword alongside a sibling `codelist` keyword. Open codelists omit the `enum`, but no open codelists exist within 360Giving at present.
Contributor
Author
|
#391 makes it clear that we are aware of the validation problems with |
mrshll1001
force-pushed
the
mm-refactor-codelist-declarations
branch
from
83a61d8 to
244b21b
Compare
mrshll1001
changed the title
geoCodeType bug and refactor codelist declarations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR represents a PATCH which Refactors the declaration of codelists in the schema to keep the schema modern and maintainable (#433)
This does not change any validation rules in the Standard; it just changes how these validation rules are declared to be more modern and maintainable. No existing data will be affected.