Remove Share modal — copy URL directly on button click#35
Merged
ThisIs-Developer merged 7 commits intomainfrom Mar 4, 2026
Merged
Remove Share modal — copy URL directly on button click#35ThisIs-Developer merged 7 commits intomainfrom
ThisIs-Developer merged 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Deploying markdown-viewer with
|
| Latest commit: |
e5fb3ae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e064eb2e.markdown-viewer.pages.dev |
| Branch Preview URL: | https://copilot-fix-large-markdown-l.markdown-viewer.pages.dev |
Deploying markdownviewer with
|
| Latest commit: |
e5fb3ae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c228dcf4.markdownviewer.pages.dev |
| Branch Preview URL: | https://copilot-fix-large-markdown-l.markdownviewer.pages.dev |
Copilot
AI
changed the title
[WIP] Fix issue with large link when sharing markdown files
Replace blocking share alert with URL modal for large markdown documents
Mar 4, 2026
Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Copilot
AI
changed the title
Replace blocking share alert with URL modal for large markdown documents
Remove generated URL display from share modal
Mar 4, 2026
Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Copilot
AI
changed the title
Remove generated URL display from share modal
Remove URL display from share modal
Mar 4, 2026
Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Copilot
AI
changed the title
Remove URL display from share modal
Remove Share modal — copy URL directly on button click
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Share button previously opened a modal dialog displaying the encoded URL. The requirement is to eliminate the modal entirely and have the button copy the URL to clipboard inline, briefly showing "Copied!".
Changes
index.html: Removed the entire#share-modaldialog blockscript.js:shareModalCopyhandler with a singlecopyShareUrl(btn)helpershareButtonandmobileShareButtoncall it directly (removed the old delegate)window.location.hashis now set only on successful clipboard write, not unconditionallystyles.css: Removed the entireSHARE URL MODALCSS section (~75 lines)On click, the button text changes to
✓ Copied!for 2 seconds, then restores. Falls back toexecCommandcopy via a transient off-screen textarea for non-secure contexts.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.