Fix invalid Docker image tag on PR builds#33
Merged
ThisIs-Developer merged 3 commits intomainfrom Mar 4, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Deploying markdown-viewer with
|
| Latest commit: |
92c2fdf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://078d9bb9.markdown-viewer.pages.dev |
| Branch Preview URL: | https://copilot-add-share-button-mar.markdown-viewer.pages.dev |
Copilot
AI
changed the title
[WIP] Add share button for URL-encoded markdown sharing
Add share button with pako-compressed URL hash for stateless markdown sharing
Mar 4, 2026
Deploying markdownviewer with
|
| Latest commit: |
92c2fdf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://808e69ee.markdownviewer.pages.dev |
| Branch Preview URL: | https://copilot-add-share-button-mar.markdownviewer.pages.dev |
Co-authored-by: ThisIs-Developer <109382325+ThisIs-Developer@users.noreply.github.com>
Copilot
AI
changed the title
Add share button with pako-compressed URL hash for stateless markdown sharing
Fix invalid Docker image tag on PR builds
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
docker/metadata-action{{branch}}placeholder resolves to an empty string onpull_requestevents, producing the tag:-afc54f8— an invalid Docker reference that fails the build.Change
.github/workflows/docker-publish.yml: Replace dynamicprefix={{branch}}-with the staticprefix=sha-, producing a consistently valid tag (sha-<short-sha>) across bothpushandpull_requestevents.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.