fix(settings): simplify danger zone entry#1681
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR consolidates the Data Settings "Danger Zone" reset UI by replacing three always-visible destructive buttons with a single low-noise outline reset entry. The confirmation dialog remains the authoritative mechanism for selecting reset type, and opening the dialog now defaults the selected type to chat. Test IDs enable stable testing coverage. ChangesData Settings Danger Zone Reset Entry
Sequence DiagramsequenceDiagram
participant User
participant DataSettings
participant ResetDialog
User->>DataSettings: Click danger-zone reset entry
DataSettings->>DataSettings: openResetDialog()
DataSettings->>DataSettings: Set resetType = 'chat'
DataSettings->>ResetDialog: Open dialog (chat selected)
User->>ResetDialog: Select option (e.g., knowledge)
ResetDialog->>ResetDialog: Update resetType
User->>ResetDialog: Click confirm
DataSettings->>DataSettings: Call devicePresenter.resetDataByType(resetType.value)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
iShot_2026-05-27_10.23.59.mp4
Summary by CodeRabbit
Documentation
New Features
Tests
Chores