Improper Map.ini causes uncaught exception crash

[DayV-git]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

This map will crash the game as it has a invalid map.ini. The debug exes state uncaught exception in GameEngine::update. Needs to be handled properly.

Alpine Assault Improper map_ini.zip

Reproduction Steps

Load map

Additional Context

No response

[ViTeXFTW]

But the Map.ini is not correctly formatted. There is not handling for DeleteKey *CommandSet*. Which is why it crashes.

[xezon]

Do the INI parse errors actually give a hint of what the error is? In Debug? Likely we should improve it and print out what exactly is wrong in INI.

[ViTeXFTW]

No, the errors are completely useless and never hint at anything unless it is a very silly mistake. At most, it will point you to the correct object that coursed the issue.

[DayV-git]

For reference, if you opened world builder (which is always debug) with an improper INI (in game files) such as this, it would give you an assertion error

⚠️ ASSERTION FAILURE: [LINE: X - FILE: 'Y.ini'] Unknown block 'DeleteKey'

Before crashing. The same should happen in debug mode of regular game.

World builder does not currently have any issues with loading .maps with bad map.inis, as they are independent.

[xezon]

I suspect the Game Client will print the same Assert Message when DEBUG_CRASHING is compiled in.