Skip to content

Add type hints to src/palace/manager/api/admin/ code.#3046

Open
dbernstein wants to merge 2 commits intomainfrom
add-type-hints-to-api-admin
Open

Add type hints to src/palace/manager/api/admin/ code.#3046
dbernstein wants to merge 2 commits intomainfrom
add-type-hints-to-api-admin

Conversation

@dbernstein
Copy link
Contributor

@dbernstein dbernstein commented Feb 12, 2026

Description

As part of the ongoing effort to add type hints everywhere. This PR adds type hints to everything below src/palace/manager/api/admin/ and tightens up an implementations that require changes due to type hint additions.

Motivation and Context

Long term team-wide effort.

How Has This Been Tested?

Tests pass. Mypy passes.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@dbernstein dbernstein force-pushed the add-type-hints-to-api-admin branch from cd03642 to 168c3c1 Compare February 13, 2026 17:16
@dbernstein dbernstein force-pushed the add-type-hints-to-api-admin branch from 168c3c1 to d4e43d6 Compare February 13, 2026 20:42
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 78.50467% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.96%. Comparing base (ebb43bf) to head (d4e43d6).

Files with missing lines Patch % Lines
src/palace/manager/api/admin/validator.py 76.47% 5 Missing and 3 partials ⚠️
...anager/api/admin/controller/collection_settings.py 30.00% 6 Missing and 1 partial ⚠️
.../manager/api/admin/controller/metadata_services.py 41.66% 6 Missing and 1 partial ⚠️
...nager/api/admin/controller/patron_auth_services.py 36.36% 6 Missing and 1 partial ⚠️
src/palace/manager/api/admin/controller/lanes.py 60.00% 6 Missing ⚠️
...alace/manager/api/admin/controller/custom_lists.py 50.00% 4 Missing ⚠️
...e/manager/api/admin/controller/catalog_services.py 71.42% 2 Missing ⚠️
...manager/api/admin/controller/discovery_services.py 71.42% 2 Missing ⚠️
...pi/admin/password_admin_authentication_provider.py 80.00% 1 Missing and 1 partial ⚠️
src/palace/manager/api/admin/routes.py 98.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3046      +/-   ##
==========================================
- Coverage   93.04%   92.96%   -0.09%     
==========================================
  Files         480      480              
  Lines       43716    43798      +82     
  Branches     6027     6034       +7     
==========================================
+ Hits        40677    40715      +38     
- Misses       1968     2005      +37     
- Partials     1071     1078       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbernstein dbernstein marked this pull request as ready for review February 17, 2026 01:34
@dbernstein dbernstein requested a review from a team February 17, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant