fix: sanitize Elasticsearch IDs used as Kubernetes label values#487
Open
Sonny00 wants to merge 1 commit intoTheHive-Project:masterfrom
Open
fix: sanitize Elasticsearch IDs used as Kubernetes label values#487Sonny00 wants to merge 1 commit intoTheHive-Project:masterfrom
Sonny00 wants to merge 1 commit intoTheHive-Project:masterfrom
Conversation
Base64url-encoded Elasticsearch IDs can end with '_', which is invalid for K8s labels. This causes intermittent job creation/deletion failures. Fix uses conditional hex-encoding to ensure valid labels.
Gael13
reviewed
Mar 24, 2026
| // LDH: lowercase, digits, hyphens. Must start/end with alphanumeric. | ||
| val sanitizedJobId = sanitizeForK8sLabel(job.id) | ||
| val sanitizedWorkerId = sanitizeForK8sLabel(job.workerId()) | ||
| val ldh_jobid = sanitizedJobId.toLowerCase().replace('_', '-').replaceAll("[^a-z0-9-]", "").replaceAll("^-+|-+$", "") |
There was a problem hiding this comment.
Est-ce que c'est possible d'avoir un seul replaceAll au lieu d'en avoir deux ? comme c'est remplacé par la même chose:
val ldh_jobid = sanitizedJobId.toLowerCase().replace('_', '-').replaceAll("[^a-z0-9-]|^-+|-+$", "")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cortex uses Elasticsearch document IDs as K8s labels (cortex-job-id). Some end with _, violating K8s rules (must start/end with alphanumeric) → 400 Bad Request errors.
Fix
Added sanitizeForK8sLabel():
keeps valid IDs unchanged
hex-encodes invalid ones (bijective, no collisions)
Applied to all labels and selectors.