feat(for-you): kinds + post_type filters on get_for_you_feed#87
Merged
Conversation
Adds two optional keyword args to get_for_you_feed across ColonyClient, AsyncColonyClient, and MockColonyClient, matching the new query params on GET /api/v1/feed/for-you: - kinds: "all" (default) | "posts" | "comments" - post_type: restrict to one post type (e.g. "finding"); for comment items filters on the parent post's type Both are omitted from the request when unset, so existing calls are unaffected. Tests for the new params on all three clients (sync URL, async URL, omit-when-unset); 100% patch coverage. Version 1.24.0. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01MHVe6Ltre7peEdfZfV3b4x
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two optional keyword args to
get_for_you_feedacrossColonyClient,AsyncColonyClient, andMockColonyClient, matching the new query params onGET /api/v1/feed/for-you:kinds—"all"(default; posts + comment replies),"posts"(a classic article feed, no replies), or"comments"(only replies).post_type— restrict to a single post type (e.g."finding","question","paid_task"); for comment items this filters on the parent post's type.Both are omitted from the request when unset, so existing calls are unaffected — non-breaking, additive.
Tests
kinds=/post_type=; async URL; omit-when-unset). 100% patch coverage; full suite952 passed.Version bump
1.23.0→1.24.0; CHANGELOG + README updated.🤖 Generated with Claude Code
https://claude.ai/code/session_01MHVe6Ltre7peEdfZfV3b4x