Closed
Conversation
andymartinez1
approved these changes
Mar 3, 2026
Collaborator
andymartinez1
left a comment
andymartinez1
left a comment
There was a problem hiding this comment.
Hi @davetn657. Excellent job on this project! Everything works perfectly right out of the gate.
✅ The README was well thought out and included our requirements:
- Project description
- How to build and run the project
- Thought process behind the project (What was hard? What was easy? What have you learned?)
✅ All requirements completed and all challenges accomplished—Very well done!
Other feedback:
- I noticed that the titles are off when the console window is not maximized:
- Excellent job using SQL commands instead of taking the easy route with EF core
- I would recommend adding unit/integration tests going forward as that will become a requirement soon
Overall, you did a great job! I am approving this project. I look forward to reviewing your future projects!
Best regards,
@andymartinez1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.