v4.3.0 release prep: version bumps + all 8 pre-release code-review fixes - #50
Merged
Merged
Conversation
- library.properties: 4.2.0 -> 4.3.0 - Doxyfile PROJECT_NUMBER: stale 4.0.0 -> 4.3.0 - CLAUDE.md version line -> 4.3.0 - CHANGELOG: move Unreleased entries under [4.3.0] - 2026-08-10 with release summary; add the 4.3.0 tag link Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TQK29n1LCebSUxf1nD12FW
12 tasks
GCC Code Coverage Report📂 Overall coverage
📄 File coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release housekeeping plus all 8 findings from the pre-release code review of BETA vs master, so v4.3.0 ships clean.
Release prep
library.properties:version=4.2.0→4.3.0Doxyfile:PROJECT_NUMBERwas stale at4.0.0→4.3.0CHANGELOG.md:[Unreleased]entries moved under## [4.3.0] – 2026-08-10(now including the fixes below), tag link addedCLAUDE.md: version line → 4.3.0Correctness fixes
CourseManager::selectCourse()stale-timer reactivation: a timer frozen by the Lap Anything fallback (or pruning) is now reset before re-activation. Pre-fix its frozenraceStarted/lap-start/position snapshot closed a bogus multi-minute "lap", permanently poisonedbestLapTime, and credited never-driven odometer distance.Contract fixes
SprintTimer::loop()return now matchesDovesLapTimer::loop(): 0 only while inside a crossing zone; the zone-exit fix returns -1.getCurrentLapStartTime(),getCurrentLapOdometerStart(),isStartFinishLineConfigured()to SprintTimer — the "full DovesLapTimer getter surface" claim is now true.test/MakefilegainedEXTRA_CXXFLAGS(appended);unit-tests.yml's kill-switch pass usesmake run EXTRA_CXXFLAGS=-DDOVES_DISABLE_DEBUGinstead of a hardcoded copy of the Makefile's flags.Hygiene
DOVES_DISABLE_DEBUGtemplate blocks deduplicated into sharedsrc/DovesDebug.h(DOVES_DEBUG_TEMPLATES()macro).SprintTimer::_crossingThresholdMetersmember removed.CLAUDE.mdstaleness: CI matrix compiles 4 examples (not 3); five debug-printing classes (not six, CourseDetector has none);DovesDebug.hdocumented.Type of change
Testing
cd test && make runpasses locally — and passes withEXTRA_CXXFLAGS=-DDOVES_DISABLE_DEBUGtest_sprint_timer.cpp::same_fix_split_and_finish_dispatch_in_crossing_ordertest_sprint_timer.cpp::loop_return_matches_circuit_contracttest_course_manager.cpp::select_course_after_fallback_resets_stale_timerduck_typed_surface_matches_run_surfaceChecklist
loop()return doc)README.md— N/A (its getter-surface claim becomes true; no text change needed)CHANGELOG.mdupdated (Fixed/Changed entries under[4.3.0])Notes for reviewers
Merge into
BETAbefore PR #49 (BETA → master), then tagv4.3.0after #49 lands. The dispatch-order fix intentionally changes behavior only when two lines complete on the same fix — the NMEA replay goldens pin that normal single-completion behavior is untouched.🤖 Generated with Claude Code
https://claude.ai/code/session_01TQK29n1LCebSUxf1nD12FW