Fix the six Low findings from the v3.0.0 release review#323
Merged
Conversation
Address all confirmed (non-blocking) findings from the BETA→main release-gate review on PR #307: - REL-01: changelog — note that an engine is now required on every vehicle. - COR-01: Leaderboards — namespace the top-session loading key by course (top:${courseKey}|${groupKey}) so same-engine groups under different courses no longer cross-disable their load buttons. - COR-02: ProfileAvatar — fall back to the UserIcon placeholder on image load error instead of the browser's broken-image glyph (resets on url change). - TST-01: export + test escapeLike (ilike wildcard escaping for /driver lookup). - TST-02: test autoSubmitSnapshotTrack skip/dedupe/invoke branches. - DOC-01: rename the branch-db plan 0006 -> 0007 (it collided with the user-profiles plan) and update its references in CLAUDE.md + README. Also adds the release-review report under docs/reviews/ for the record. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VUypCCbFtY85CaHxj9VWE6
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Coverage SummaryLines: 58.69% (6356/10829) · Statements: 57.64% · Functions: 56.01% · Branches: 53.58% Per-file coverage
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lapwing | c9e915f | Commit Preview URL Branch Preview URL |
Jun 30 2026, 04:23 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all six confirmed (Low, non-blocking) findings from the BETA→main release-gate review on #307. None gated the release; this clears them so 3.0.0 ships clean.
[3.0.0]top:${courseKey}|${groupKey}(mirrors the disclosure key)ProfileAvatarrendered the browser broken-image glyph when an avatar URL 404'donErrorfallback to theUserIconplaceholder (resets onurlchange)escapeLike()(ilike wildcard escaping for/driver/:username) had no testpublicProfile.test.ts(_,%,\, mixed, passthrough, empty)autoSubmitSnapshotTrack()skip/dedupe/invoke branches untestedtrackAutoSubmit.test.tsmocking the dynamic imports +functions.invokefor each branch0006(Golden Rule 8 collision)0007-dynamic-supabase-branch-db.md+ updated its title and the branch-dbplan 0006refs in CLAUDE.md/README (user-profiles refs stay 0006)Also adds the release-review report under
docs/reviews/for the record.Related Issues
Follow-up to the release review on #307.
Type of Change
Checklist
bun run lintpassesbun run typecheckpassesbun run test:runpasses (2098 tests; +12 from the two new test files)bun run buildsucceedsCHANGELOG.md,CLAUDE.md,README.md, plan rename)Notes for Reviewers
All changes are low-risk: two tiny UI fixes, two new tests around existing logic, one changelog line, and a docs/plan rename. The
[3.0.0]heading is already dated — the engine-required bullet documents a change that shipped in 3.0.0, so it belongs under that heading rather than a new one.🤖 Generated with Claude Code
Generated by Claude Code