Skip to content

Conversation

@yaadhuu
Copy link

@yaadhuu yaadhuu commented Jan 22, 2026

Summary

This pull request improves the clarity and robustness of
kth_lexicographic_permutation without changing the underlying algorithm.

Changes

  • Fixed a docstring inconsistency to correctly describe the permutation range
    as 0, 1, 2, ..., n-1.
  • Corrected a small typo in a comment.
  • Replaced the use of assert with explicit input validation using
    TypeError and ValueError for clearer and more reliable error handling.
  • Used pop(index) instead of remove(value) to make element removal
    intent explicit.

Why this change

These changes improve correctness, readability, and alignment with Python
best practices while keeping the algorithm logic and behavior unchanged.
All existing doctests continue to pass.

Scope

This PR is intentionally minimal and limited to a single file.

@algorithms-keeper
Copy link

Closing this pull request as invalid

@yaadhuu, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant