Skip to content

Conversation

@P09s
Copy link

@P09s P09s commented Jan 12, 2026

Implements the classic sliding window maximum problem (LeetCode 239) using a monotonic deque for O(n) time.

Features:

  • Full Google-style docstring with examples and complexity analysis
  • Type hints
  • Doctests for normal + edge cases
  • Clean, educational code following repo standards

Ready for review!

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jan 12, 2026
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Jan 12, 2026
@P09s
Copy link
Author

P09s commented Jan 12, 2026

Hi maintainers! @poyea @cclauss @mindaugl

  • Updated the implementation with modern type hints (list[int], deque[int]) to satisfy Ruff rules (UP006/UP035)
  • Fixed end-of-file newline
  • All CI checks are now green (ruff, pre-commit.ci, build, docs)
  • Tests pass, label removed automatically

Ready for review! Would appreciate any feedback
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant