fix: heap-buffer-overflow in prime factorization (Range allocation size)#1574
Closed
SAY-5 wants to merge 1 commit into
Closed
fix: heap-buffer-overflow in prime factorization (Range allocation size)#1574SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
malloc(sizeof(range)) allocated only pointer size instead of the full struct, causing a heap-buffer-overflow when writing pstr->length. Use sizeof(*pstr) so the whole struct is allocated. Fixes TheAlgorithms#1568.
SAY-5
requested review from
Panquesito7,
alexpantyukhin and
tjgurwara99
as code owners
Author
|
Closing as duplicate of my earlier #1573. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1568.
int_fact()allocated theRangestruct withmalloc(sizeof(range)), whererangeis anint *local variable, so only pointer-size bytes were allocated. Writingpstr->lengththen ran past the end of the allocation, which AddressSanitizer flags as a heap-buffer-overflow.Changed to
malloc(sizeof(*pstr))so the fullstruct datais allocated.Built locally with
-fsanitize=address,undefined; ASan no longer reports the overflow.