(DO NOT MERGE) dbSta: Add delay calculator runtime regressions - #11200
Draft
jhkim-pii wants to merge 3 commits into
Draft
(DO NOT MERGE) dbSta: Add delay calculator runtime regressions#11200jhkim-pii wants to merge 3 commits into
jhkim-pii wants to merge 3 commits into
Conversation
Add pass/fail Tcl regressions that measure complete required-time updates with the default Elmore and Lambert-W delay models. Share the measurement and QoR stability checks across nine existing timing fixtures and expose only the fixture data required by Bazel. Keep runtime ordering informational because it depends on design and thread count. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Add the required spacing to the empty Tcl argument list so tclfmt accepts the shared runtime helper. This restores fmt_tcl_test without changing test behavior. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a suite of integration tests to compare the full timing-update runtimes of the Elmore and Lambert-W delay calculators across multiple designs, including ASAP7, Nangate45, and GF180. It adds several test scripts, helper utilities, and updates Bazel and CMake configurations to support these pass/fail tests. The review feedback suggests simplifying conditional expressions in the Bazel build file to direct booleans for better readability, and replacing lsearch with remove_from_collection in the Tcl test script to ensure robust handling of OpenSTA collections.
Simplify the PASSFAIL Bazel conditions and use the OpenSTA-native all_inputs -no_clocks option for the ASAP7 RISC-V constraints. This keeps timing behavior unchanged while making the test setup more direct and readable. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Tcl regressions comparing
dmp_ceff_elmoreanddmp_ceff_lambert_wwith fullfind_requiredstiming updates-threads 64tests, Lambert W dcalc is slower.STA full timing update runtime
-threads 1-threads t64dmp_ceff_elmoredelay calculatordmp_ceff_lambert_wdelay calculatorRuntime measurement
asap7_aesasap7_gcdasap7_riscvexample1gf180_jpegmock_arraynangate45_dynamic_nodenangate45_gcdnangate45_ibexHow to run
asap7/aeswith 64 threadsbazel build //:openroad cd src/dbSta/test ../../../bazel-bin/openroad -threads 64 -no_splash -no_init -exit dcalc_full_update_runtime_asap7_aes.tclExample output