rsz: Run findBufferSizes before annotating slews in performEarlySizingRound - #11195
rsz: Run findBufferSizes before annotating slews in performEarlySizingRound#11195mikesinouye wants to merge 2 commits into
Conversation
…gRound Signed-off-by: Mike Inouye <mikeinouye@google.com> Co-authored-by: Simon Bucher <ebners@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request moves the call to findBufferSizes() to the beginning of the RepairDesign::performEarlySizingRound function, ensuring it executes before user annotations are tracked and other processing occurs. There are no review comments, and I have no feedback to provide.
Signed-off-by: Mike Inouye <mikeinouye@google.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c52ede8043
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| void RepairDesign::performEarlySizingRound(int& repaired_net_count) | ||
| { | ||
| debugPrint(logger_, RSZ, "early_sizing", 1, "Performing early sizing round."); | ||
| findBufferSizes(); |
There was a problem hiding this comment.
When tgt_slew_corner_ is null—the state this change is intended to handle—findBufferSizes() does not populate it: that function only calls findFastBuffers(), which may return immediately for a populated buffer cache and never invokes findBufferTargetSlews(). The corner is actually assigned by findBufferTargetSlews() through findTargetLoads(), so the subsequent setAnnotatedSlew() can still receive a null corner and reproduce the reported crash; initialize the target loads/slews before annotating instead.
AGENTS.md reference: AGENTS.md:L20-L20
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Codex comment looks valid.
Can findBufferSizes() make tgt_slew_corner_ non-null?
2 participants
Summary
RepairDesign::performEarlySizingRound()iterates over drivers and callssta_->setAnnotatedSlew(drvr, resizer_->tgt_slew_corner_, ...)beforefindBufferSizes()is called.tgt_slew_corner_can be nullptr iffindBufferSizes()had not executed yet at that point (or any other command that would have populated it).Type of Change
Impact
Prevent a sigill in repair_design -pre_placement
Verification
./etc/Build.sh).