pdn: dont rely on just the intersection for via insertion, check actual layer shape if initial ensure does not yield valid vias - #11193
Conversation
…al layer shape if initial ensure does not yield valid vias Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
There was a problem hiding this comment.
Code Review
This pull request introduces the calculation and application of spare enclosures for bottom and top layers during via generation, updating enclosure checks and disabling caching when spare enclosures are applied. The feedback suggests simplifying the code in ViaGenerator::determineRowsAndColumns by removing redundant duplicate variables (double_enc_x_lower/double_enc_x_upper and double_enc_y_lower/double_enc_y_upper) that have identical values and can be merged back into single variables.
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
|
The whittle test fails I don't know how this relates to this change. |
|
@maliberty I saw that too, I can't imagine that it's related, I didn't look that closely at the test. It's possible retriggering it will clear it. |
|
@maliberty the rerun failed in new ways. Seems like the CI is having some issues. |
Summary
If the overlap / intersection does not allow for any enclosure, PDN would just reject that via, this change ensures we add back the enclosure from the actual shape if possible when the via enclosure is violated.
Type of Change
Impact
Allows for vias to be inserted with thinner metals
Verification
./etc/Build.sh).