pad: reorganize RDLRoute into per net to allow to better route continuity checking - #11187
Open
gadfort wants to merge 4 commits into
Open
pad: reorganize RDLRoute into per net to allow to better route continuity checking#11187gadfort wants to merge 4 commits into
gadfort wants to merge 4 commits into
Conversation
…uety checking Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the RDL router by splitting the RDLRoute class into RDLNet (representing a net) and RDLSegment (representing individual routing segments), updating the router, GUI, and tests accordingly. The review feedback highlights a potential crash in RDLNet::finalizeSegments() if segments_ is empty, a logical bug in RDLSegment::getUnroutedTerminals() that incorrectly reports all terminals as unrouted, and an optimization opportunity in RDLNet::isRouted() to include a fast-path check and prevent redundant recursive calls.
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This moves all the routing segments into a single net object to allow to better checking of route completeness. Before is a route contained 3 or more bumps, one of the segments would be unrouted. This ensures we check the net continuity before continuing.
There is some testing noise because this removes a redundant segment and changes the order of routing slightly.
Type of Change
Impact
Complete routes on daisychained bumps
Verification
./etc/Build.sh).