gpl: do not ignore endcaps - #11181
Open
gudeh wants to merge 6 commits into
Open
Conversation
…re ENCAPS in gpl Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
…isCoreAutoPlaceable
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the instance filtering criteria in PlacerBaseCommon::init to use isCoreAutoPlaceable(), aligning it with the criteria used by DPL. This ensures that instances like endcaps and welltaps, which occupy placement sites but are not strictly core or block types, are correctly recognized as obstacles. Additionally, a comprehensive unit test suite (placer_base_test.cpp) has been added to verify the classification and visibility of all dbMasterType values. There are no review comments, and I have no additional feedback to provide.
LucasYuki
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Current code is wrongfully ignoring some endcaps. To fix it we use the same ignore criteria as DPL for instantiating dbInsts as GCells inside GPL.
Type of Change
Impact
Experiments show less DPL iterations required. I observed negotiation taking most of its iterations at edges, exactly where GPL was ignoring endcaps (resulting in higher density placement).
PDKs gf180 and two private PDKs.
Verification
./etc/Build.sh).