Skip to content

gpl: vertically merge unusable site dummy instances #11085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oharboe wants to merge 14 commits into
base: master
Choose a base branch
from
Open

gpl: vertically merge unusable site dummy instances #11085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e4c966e
gpl: vertically merge unusable site dummy instances
oharboe Aug 6, 2026
32a46f6
gpl: simplify grid marking loop and format code
oharboe Aug 6, 2026
4c9b64b
gpl: optimize index calculation in vertical merge search
oharboe Aug 6, 2026
a2ee86e
gpl: use std::all_of and std::fill in vertical dummy merge
oharboe Aug 6, 2026
b850f21
gpl: use explicit SiteInfo::Blocked enum scope
oharboe Aug 6, 2026
3de5ec5
gpl: update golden files for dummy merging
oharboe Aug 6, 2026
63a39ea
test: update upf_test golden files
oharboe Aug 6, 2026
c7b8f91
ci: trigger rebuild for PR 11085
oharboe Aug 7, 2026
32c444d
test: update upf_aes golden files for dummy merging
oharboe Aug 7, 2026
8bbd249
Merge branch 'master' into pr-11085
oharboe Aug 13, 2026
423f342
Merge remote-tracking branch 'origin/master' into gpl-vertical-merge-…
oharboe Aug 14, 2026
5b35d06
test: update upf_aes golden log
oharboe Aug 14, 2026
3e293bc
test: update upf_aes golden files from CI
oharboe Aug 14, 2026
2eb8ed7
test: remove Differences found from upf_aes golden log
oharboe Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/gpl/src/placerBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1453,10 +1453,27 @@ void PlacerBase::initInstsForUnusableSites()
i++;
}
int endX = i;
int endY = j + 1;
for (; endY < siteCountY; endY++) {
const int64_t base_idx = static_cast<int64_t>(endY) * siteCountX;
auto first = siteGrid.begin() + base_idx + startX;
auto last = siteGrid.begin() + base_idx + endX;
if (!std::all_of(first, last, [](SiteInfo s) {
return s == SiteInfo::Blocked;
})) {
break;
}
}
for (int y = j; y < endY; y++) {
const int64_t base_idx = static_cast<int64_t>(y) * siteCountX;
std::fill(siteGrid.begin() + base_idx + startX,
siteGrid.begin() + base_idx + endX,
SiteInfo::FixedInst);
}
Comment thread
oharboe marked this conversation as resolved.
Comment thread
oharboe marked this conversation as resolved.
Comment thread
oharboe marked this conversation as resolved.
Instance dummy_gcell(region_bbox_.xMin() + (siteSizeX_ * startX),
region_bbox_.yMin() + (siteSizeY_ * j),
region_bbox_.xMin() + (siteSizeX_ * endX),
region_bbox_.yMin() + (siteSizeY_ * (j + 1)));
region_bbox_.yMin() + (siteSizeY_ * endY));
instStor_.push_back(dummy_gcell);
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/gpl/test/region01.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ Using 2 tracks default min distance between IO pins.
[INFO GPL-0037] Total instances area: 6974.189 um^2
[INFO GPL-0035] Pin density area adjust: 477.053 um^2
[INFO GPL-0032] ---- Initialize Region: Top-level
[INFO GPL-0006] Number of instances: 103
[INFO GPL-0006] Number of instances: 2
[INFO GPL-0007] Movable instances: 0
[INFO GPL-0008] Fixed instances: 0
[INFO GPL-0009] Dummy instances: 103
[INFO GPL-0009] Dummy instances: 2
[INFO GPL-0010] Number of nets: 666
[INFO GPL-0011] Number of pins: 2059
[INFO GPL-0012] Die BBox: ( 0.000 0.000 ) ( 377.475 377.475 ) um
Expand Down
574 changes: 287 additions & 287 deletions src/gpl/test/simple01-obs.defok
View file
Open in desktop

Large diffs are not rendered by default.

52 changes: 26 additions & 26 deletions src/gpl/test/simple01-obs.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
[INFO GPL-0037] Total instances area: 569.772 um^2
[INFO GPL-0035] Pin density area adjust: 49.963 um^2
[INFO GPL-0032] ---- Initialize Region: Top-level
[INFO GPL-0006] Number of instances: 700
[INFO GPL-0006] Number of instances: 693
[INFO GPL-0007] Movable instances: 294
[INFO GPL-0008] Fixed instances: 0
[INFO GPL-0009] Dummy instances: 406
[INFO GPL-0009] Dummy instances: 399
[INFO GPL-0010] Number of nets: 364
[INFO GPL-0011] Number of pins: 1122
[INFO GPL-0012] Die BBox: ( 0.000 0.000 ) ( 30.970 30.800 ) um
Expand Down Expand Up @@ -46,30 +46,30 @@ Automatically adjusting to uniform density 0.8500.
Iteration | Overflow | HPWL (um) | HPWL(%) | Penalty | Group
---------------------------------------------------------------
0 | 0.8474 | 1.844799e+03 | +0.00% | 3.18e-11 |
10 | 0.7619 | 2.118796e+03 | +14.85% | 5.18e-11 |
20 | 0.7613 | 2.114912e+03 | -0.18% | 8.43e-11 |
30 | 0.7586 | 2.124863e+03 | +0.47% | 1.37e-10 |
40 | 0.7530 | 2.138970e+03 | +0.66% | 2.24e-10 |
50 | 0.7432 | 2.158945e+03 | +0.93% | 3.64e-10 |
60 | 0.7287 | 2.186938e+03 | +1.30% | 5.93e-10 |
70 | 0.7064 | 2.224046e+03 | +1.70% | 9.67e-10 |
80 | 0.6787 | 2.267072e+03 | +1.93% | 1.57e-09 |
90 | 0.6435 | 2.316965e+03 | +2.20% | 2.56e-09 |
100 | 0.6031 | 2.368563e+03 | +2.23% | 4.18e-09 |
110 | 0.5583 | 2.417651e+03 | +2.07% | 6.81e-09 |
120 | 0.5062 | 2.447753e+03 | +1.25% | 1.11e-08 |
130 | 0.4403 | 2.449347e+03 | +0.07% | 1.81e-08 |
140 | 0.3901 | 2.485381e+03 | +1.47% | 2.94e-08 |
150 | 0.3349 | 2.511983e+03 | +1.07% | 4.74e-08 |
160 | 0.3093 | 2.548749e+03 | +1.46% | 6.99e-08 |
170 | 0.2772 | 2.577798e+03 | +1.14% | 1.03e-07 |
180 | 0.2407 | 2.602505e+03 | +0.96% | 1.52e-07 |
190 | 0.2098 | 2.623438e+03 | +0.80% | 2.23e-07 |
200 | 0.1804 | 2.646794e+03 | +0.89% | 3.29e-07 |
210 | 0.1547 | 2.667530e+03 | +0.78% | 4.85e-07 |
220 | 0.1344 | 2.687798e+03 | +0.76% | 7.14e-07 |
230 | 0.1190 | 2.701313e+03 | +0.50% | 1.05e-06 |
237 | 0.0993 | 2.709137e+03 | | 1.43e-06 |
10 | 0.7619 | 2.118789e+03 | +14.85% | 5.18e-11 |
20 | 0.7613 | 2.114928e+03 | -0.18% | 8.43e-11 |
30 | 0.7586 | 2.124843e+03 | +0.47% | 1.37e-10 |
40 | 0.7530 | 2.138963e+03 | +0.66% | 2.24e-10 |
50 | 0.7432 | 2.158943e+03 | +0.93% | 3.64e-10 |
60 | 0.7287 | 2.186941e+03 | +1.30% | 5.93e-10 |
70 | 0.7064 | 2.224075e+03 | +1.70% | 9.67e-10 |
80 | 0.6787 | 2.267073e+03 | +1.93% | 1.57e-09 |
90 | 0.6435 | 2.316958e+03 | +2.20% | 2.56e-09 |
100 | 0.6031 | 2.368574e+03 | +2.23% | 4.18e-09 |
110 | 0.5583 | 2.417665e+03 | +2.07% | 6.81e-09 |
120 | 0.5062 | 2.447760e+03 | +1.24% | 1.11e-08 |
130 | 0.4403 | 2.449360e+03 | +0.07% | 1.81e-08 |
140 | 0.3901 | 2.485439e+03 | +1.47% | 2.94e-08 |
150 | 0.3349 | 2.511935e+03 | +1.07% | 4.74e-08 |
160 | 0.3094 | 2.548740e+03 | +1.47% | 6.99e-08 |
170 | 0.2772 | 2.577858e+03 | +1.14% | 1.03e-07 |
180 | 0.2408 | 2.602478e+03 | +0.96% | 1.52e-07 |
190 | 0.2098 | 2.623465e+03 | +0.81% | 2.23e-07 |
200 | 0.1805 | 2.646747e+03 | +0.89% | 3.29e-07 |
210 | 0.1547 | 2.667470e+03 | +0.78% | 4.85e-07 |
220 | 0.1344 | 2.687743e+03 | +0.76% | 7.14e-07 |
230 | 0.1190 | 2.701428e+03 | +0.51% | 1.05e-06 |
237 | 0.0991 | 2.709164e+03 | | 1.43e-06 |
---------------------------------------------------------------
[INFO GPL-1001] Global placement finished at iteration 237
[INFO GPL-1002] Placed Cell Area 619.7347
Expand Down
Loading
Loading