Update ca53 metrics - #4451
Conversation
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request relaxes the finish__timing__hold__tns threshold from -1600.0 to -2520.0 in the base rules. Feedback indicates that this change allows significant hold violations to pass CI, which poses a high risk to silicon functionality. It is recommended to resolve the underlying hold violations, potentially by enabling incremental repair, rather than relaxing the threshold.
| }, | ||
| "finish__timing__hold__tns": { | ||
| "value": -1600.0, | ||
| "value": -2520.0, |
There was a problem hiding this comment.
Relaxing the finish__timing__hold__tns threshold to -2520.0 allows significant hold violations to pass CI. Hold violations are fatal to silicon functionality and cannot be mitigated by reducing clock frequency. Accepting a large negative hold TNS of -2520.0 increases the risk of masking critical physical design failures. Instead of relaxing this threshold, resolve the underlying hold violations. For example, enabling incremental repair in config.mk (by setting SKIP_INCREMENTAL_REPAIR to 0 or removing it) allows the optimizer to fix these hold violations automatically.
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.
|
2 participants
designs/gf12/ca53/rules-base.json updates: