Update misc metrics for small diffs#4312
Open
maliberty wants to merge 1 commit into
Open
Conversation
designs/gf12/bp_single/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | synth__design__instance__area__stdcell | 1020000.0 | 156000.0 | Tighten | | cts__timing__setup__tns | -331000.0 | -311000.0 | Tighten | | globalroute__timing__setup__tns | -32700.0 | -33700.0 | Failing | | finish__timing__setup__tns | -1600.0 | -1590.0 | Tighten | designs/gf12/bp_dual/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -1480000.0 | -1500000.0 | Failing | | finish__timing__setup__tns | -1180.0 | -1170.0 | Tighten | designs/gf12/bp_quad/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | placeopt__design__instance__area | 1503890 | 1497196 | Tighten | | placeopt__design__instance__count__stdcell | 1472164 | 1455380 | Tighten | | cts__design__instance__count__setup_buffer | 128014 | 126555 | Tighten | | cts__design__instance__count__hold_buffer | 128014 | 126555 | Tighten | | cts__timing__setup__ws | -375.0 | -313.0 | Tighten | | cts__timing__setup__tns | -393000.0 | -247000.0 | Tighten | | globalroute__antenna_diodes_count | 1125 | 1107 | Tighten | | globalroute__timing__setup__ws | -223.0 | -133.0 | Tighten | | globalroute__timing__setup__tns | -4160.0 | -702.0 | Tighten | | detailedroute__route__drc_errors | 0 | 1 | Failing | | detailedroute__antenna_diodes_count | 1131 | 1110 | Tighten | | finish__timing__setup__ws | -225.0 | -219.0 | Tighten | | finish__timing__setup__tns | -1730.0 | -1620.0 | Tighten | | finish__design__instance__area | 1534801 | 1524210 | Tighten | designs/sky130hd/chameleon/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__antenna_diodes_count | 207 | 209 | Failing | | detailedroute__route__wirelength | 846595 | 846125 | Tighten | | finish__timing__setup__ws | -0.282 | -0.28 | Tighten | designs/sky130hd/microwatt/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__antenna_diodes_count | 1271 | 1276 | Failing | | detailedroute__antenna_diodes_count | 1411 | 1341 | Tighten | | finish__timing__setup__ws | -2.73 | -2.69 | Tighten | | finish__timing__hold__ws | -0.991 | -0.989 | Tighten | | finish__design__instance__area | 5575821 | 5575637 | Tighten | Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the baseline regression rules for several designs, including bp_dual, bp_quad, bp_single, chameleon, and microwatt, by adding synthesis netlist hashes and adjusting various physical design, area, and timing thresholds. Feedback is provided regarding the bp_quad design, where the allowable DRC errors were increased from 0 to 1; the reviewer notes that permitting DRC errors can lead to manufacturing violations and requests confirmation of an agreement or tracked issue to address this degradation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
designs/gf12/bp_single/rules-base.json updates:
designs/gf12/bp_dual/rules-base.json updates:
designs/gf12/bp_quad/rules-base.json updates:
designs/sky130hd/chameleon/rules-base.json updates:
designs/sky130hd/microwatt/rules-base.json updates: