Port from SideStore: App Info viewer (B) + PillButton cached-state fix (F)#71
Merged
Conversation
…clears Ported from SideStore 15a58c8. The progress observer captured isUserInteractionEnabled, set isIndicatingActivity, then unconditionally restored the captured value — so when progress cleared, a stale captured value could leave the button disabled. Restore only while progress is active; let isIndicatingActivity = false re-enable interaction otherwise. https://claude.ai/code/session_01PT8zpkUrgTRaGeKmbvVyNe
Ports SideStore's App Info viewer (4f32e4c + follow-ups) into MiniStore: a
per-app inspector for My Apps entries showing general metadata, the
provisioning profile (team, dates, entitlements, provisioned devices), app
extensions, an Info.plist viewer (semantic / raw XML / tree), and a bundle
resource browser with QuickLook preview and export. Reads only the local app
bundle (Bundle, Info.plist, embedded.mobileprovision via AltSign's
ALTProvisioningProfile) — no minimuxer/AltSign network APIs.
Adaptations for MiniStore: SwiftUI.Button / SwiftUI.Label to avoid the
app-local UIButton `Button` shadow; NavigationView -> NavigationStack; wired
into the My Apps context menu ("App Info") presenting AppInfoView as a sheet.
https://claude.ai/code/session_01PT8zpkUrgTRaGeKmbvVyNe
AppDetailView already declares a (file-private) EntitlementRow; the ported
App Info viewer's internal EntitlementRow clashed at module scope ("invalid
redeclaration"). Rename the ported one to AppInfoEntitlementRow.
https://claude.ai/code/session_01PT8zpkUrgTRaGeKmbvVyNe
…n pin - ALTProvisioningProfile.UUID -> .uuid (MiniStore's AltSign pin lowercases it). - unzipAppBundle(at:to:) -> (at:toDirectory:) (MiniStore's label). - Drop the NavigationLink to CertificateDetailView (part of the un-ported cert management group); show the certificate inline instead. https://claude.ai/code/session_01PT8zpkUrgTRaGeKmbvVyNe
Contributor
|
Builds for this Pull Request are available at |
Contributor
|
Download the artifacts for this pull request (nightly.link): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two SideStore ports: the App Info / bundle inspector feature (group B) and a PillButton bug fix (group F).
Type of change
Changes
B — App Info viewer (ports SideStore
4f32e4c+ follow-ups). A per-app inspector opened from the My Apps long-press menu ("App Info", presented as a sheet):Bundle,Info.plist,embedded.mobileprovisionvia AltSignALTProvisioningProfile) — no minimuxer / network APIs.AppInfoView.swift,InfoPlistContainerView.swift,BundleResourceBrowserView.swift. Adapted for MiniStore:SwiftUI.Button/SwiftUI.Label(dodge the app-localButtonshadow),NavigationView→NavigationStack, wired into the SwiftUI context menu + sheet.F — PillButton cached state (ports SideStore
15a58c8). The progress observer restored a capturedisUserInteractionEnabledunconditionally, so when progress cleared a stale value could leave the button disabled. Restore only while progress is active.Other F candidates were verified N/A: MiniStore's Deactivate/RemoveAppOperation already call
try context.save()(0ff348c), and MiniStore has nocompletionHandler?([:])refresh path (9cfb121).Testing
CI is the compile check (validates the ~2k-line port). On device: long-press a My Apps entry → App Info → inspect metadata / Info.plist / bundle resources; a refreshing pill button re-enables correctly after progress clears.
Checklist
develop(nevermain)CLAUDE.md🤖 Generated with Claude Code
Generated by Claude Code