Skip to content

fix(OrthoPerspectiveCamera): safeguard zero size #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShaMan123 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(OrthoPerspectiveCamera): safeguard zero size #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9631a71
fix(OrthoPerspectiveCamera): safeguard zero size
ShaMan123 Aug 22, 2026
5d6c9fe
fixes
ShaMan123 Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/src/core/OrthoPerspectiveCamera/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,11 @@ export class OrthoPerspectiveCamera extends SimpleCamera {

const size = this.currentWorld.renderer.getSize();

if (this.previousSize.x === 0 || this.previousSize.y === 0) {
this.previousSize.copy(size);
return;
}

const previousHeight = this.threeOrtho.top;
const previousWidth = this.threeOrtho.right;

Expand Down
10 changes: 10 additions & 0 deletions packages/core/src/core/Worlds/src/simple-camera.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,16 @@ export class SimpleCamera extends BaseCamera implements Updateable, Disposable {
*/
updateAspect = () => {
if (!this.currentWorld || !this.currentWorld.renderer) return;
if (this.currentWorld.renderer?.isResizeable()) {
const currentSize = this.currentWorld.renderer.getSize();
// A collapsed or hidden container draws nothing.
// There is no aspect to derive from it, while applying one is
// destructive in both projections: a perspective camera takes
// `aspect = 0`, i.e. a non-finite projection matrix, and an orthographic
// one gets its extents scaled to zero.
// Keep the frustum we have.
if (currentSize.width === 0 || currentSize.height === 0) return;
}
if (this.three instanceof THREE.OrthographicCamera) {
this.onAspectUpdated.trigger();
return;
Expand Down