Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced internal main-thread assertions using
ASDisplayNodeCAssertMainThread()with explicit[NSThread isMainThread]checks inASInternalHelpers.mm.Why this change
SwiftUI Previews run in a separate lightweight process (PreviewHost / XCPreviewAgent). While
Thread.isMainThread/[NSThread isMainThread]returnstrue(because PreviewHost fakes the Foundation main thread for compatibility with SwiftUI, UIKit, and@MainActor), lower-level or custom main-thread checks (like the previous macro) could fail or behave inconsistently.This caused assertion failures or skipped initialization/cleanup logic during preview rendering, leading to crashes or broken previews.