uboot/splash: add splash screen documentation for AM62PX, J722S and AM62LX#753
uboot/splash: add splash screen documentation for AM62PX, J722S and AM62LX#753lucifer-9852 wants to merge 3 commits into
Conversation
… and AM62LX Signed-off-by: Rahul Sharma <r-sharma3@ti.com>
Signed-off-by: Rahul Sharma <r-sharma3@ti.com>
Signed-off-by: Rahul Sharma <r-sharma3@ti.com>
|
New warnings found with rstcheck: |
| .. ifconfig:: CONFIG_part_variant in ('J722S') | ||
|
|
||
| 1. Add video driver and panel node in the dts file. Panel-specific device-tree overlays are | ||
| selected via config fragments — see `Panel-specific config fragments`_ for details. | ||
|
|
There was a problem hiding this comment.
This file needs to be cleaned up at some point. No reason to interlace different steps for each machine. Additionally, splitting a list with any other content type at the same or higher indentation level actually results in 2 list elements, mangling templates.
There was a problem hiding this comment.
Considering this PR is doubling the size of this problematic section, could you look into resolving that?
| * - Panel | ||
| - Config fragments required | ||
| * - OLDI Microtips MF101HIE | ||
| - :file:`configs/am62p5_j722s_evm_oldi-microtips-mf101hie-panel.config` |
There was a problem hiding this comment.
Isn't this already included by default in current sdk ?
| .. ifconfig:: CONFIG_part_variant in ('J722S') | ||
|
|
||
| 2. Enable the A53 SPL splash screen related configurations. The :file:`configs/j722s_evm_a53_defconfig` | ||
| already includes :file:`configs/am62x_a53_splashscreen.config` so splash screen is enabled by default. |
There was a problem hiding this comment.
The above config fragment is specific to a53 spl splash.
There are below two sections in the document:
-
How to run splash in uboot proper via cmdline -> Highlight extra Kconfigs which need to be enabled, Kconfigs which need to be disabled etc.
-
How to run splash with upstream uboot -> I think we would need to hide this section for now as patches are not posted upstream
You need to document steps for above two sections too for the new platforms and interfaces which were added and until then these two sections should not give false information for j722s or the dsi interfaces for am62p, am62l, j722s.
|
|
||
| .. ifconfig:: CONFIG_part_variant in ('J722S') | ||
|
|
||
| 1. Add video driver and panel node in the dts file. Panel-specific device-tree overlays are |
There was a problem hiding this comment.
I guess we don't need to add video driver and panel node for any of the platforms now or AM62 is still following the old style?
Also for J722S and other platforms there is a direct overlay so we don't need to mention "Add video driver and panel node in the dts file"
fragment table (OLDI and DSI panels) and build commands.
env variables, panel config fragment table (OLDI, DSI, eDP) and build
commands.
variables with correct DDR load address (0x82200000), panel config
fragment table (DSI) and build commands; add warning that display
pipeline drivers must be built-in (=y) in Linux kernel when U-Boot
splash is enabled.