Skip to content

fix(auth): honor request timeout during configure#52

Open
JerryNee wants to merge 1 commit into
TestSprite:mainfrom
JerryNee:fix/configure-request-timeout
Open

fix(auth): honor request timeout during configure#52
JerryNee wants to merge 1 commit into
TestSprite:mainfrom
JerryNee:fix/configure-request-timeout

Conversation

@JerryNee

Copy link
Copy Markdown

Summary

  • pass requestTimeoutMs into the pre-write /me validation client used by auth configure / setup
  • ensure a configured short request timeout also bounds the key-validation ping before credentials are written
  • add regression coverage that proves the validation fetch receives an abort signal and credentials are not persisted on timeout

Why

runConfigure builds a one-off HttpClient so it can validate the candidate key before writing credentials. That path bypassed makeHttpClient, so the global --request-timeout value was parsed but not applied to the validation ping.

Verification

  • npm test -- src/commands/auth.test.ts
  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant