Skip to content

fix(help): include request-timeout in global flag guidance#41

Open
JerryNee wants to merge 1 commit into
TestSprite:mainfrom
JerryNee:fix/request-timeout-global-help
Open

fix(help): include request-timeout in global flag guidance#41
JerryNee wants to merge 1 commit into
TestSprite:mainfrom
JerryNee:fix/request-timeout-global-help

Conversation

@JerryNee

Copy link
Copy Markdown

What

--request-timeout is a global flag, but it was missing from two pieces of global-flag guidance:

  • the helper that rephrases misplaced global flags after subcommands
  • the shared GLOBAL_OPTS_HINT footer appended to subcommand help text

Why

When a user places a known global flag after a subcommand, the CLI tries to turn Commander’s generic unknown option message into an actionable hint. --request-timeout should get the same treatment as --output, --profile, and --endpoint-url.

Changes

  • Add request-timeout to the global flag arity table as a value flag.
  • Include --request-timeout in the shared global options help footer.
  • Add regression tests for the rephrased misplaced-flag message.
  • Refresh help snapshots for the updated footer.

Verification

  • npx vitest run src/lib/render-error.test.ts test/help.snapshot.test.ts -u
  • npm run typecheck
  • npm run lint
  • npm run format:check
  • npm test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant