Conversation
|
I do only see 1 added line in |
|
oooof, I forgot to commit the files, and I have since wiped them out. I will re-implement it. |
dboehmer
left a comment
dboehmer
left a comment
There was a problem hiding this comment.
I didn’t run your code but looked at the diff only.
| my $fd = $event->facet_data; | ||
|
|
||
| if (my $line = $.) { | ||
| my $fh = eval '$${^LAST_FH}' || do { # Added in 5.18, the do is fallback |
There was a problem hiding this comment.
Shouldn’t this check the Perl version instead of string eval?
|
|
||
| our $VERSION = '0.000154'; | ||
|
|
||
| use B(); |
There was a problem hiding this comment.
Would you consider a space to make this distinct from a function call?
| use B(); | |
| use B (); |
| @@ -1,5 +1,7 @@ | |||
| {{$NEXT}} | |||
|
|
|||
| - Add Test2::Plugin::DebugOnFail | |||
There was a problem hiding this comment.
Looks like this was the name of your previous attempt. I consider DataLine a better name.
| $out = $msg; | ||
| }; | ||
| warn "blah"; | ||
| $out =~ m/<(.+)> line $line/ ? $1 : '?'; |
There was a problem hiding this comment.
Could we make this regex more specific? What if the test name contains line?
I don’t understand why there are <> in this regex. You don’t want to utilize //x for compatibility, right?
2 participants
No description provided.