Skip to content

fix(ci): drop extracted pkg/registry + pkg/secure from arch-gates#182

Merged
TeoSlayer merged 1 commit into
mainfrom
fix/architecture-gates-extracted-packages
May 30, 2026
Merged

fix(ci): drop extracted pkg/registry + pkg/secure from arch-gates#182
TeoSlayer merged 1 commit into
mainfrom
fix/architecture-gates-extracted-packages

Conversation

@TeoSlayer
Copy link
Copy Markdown
Owner

Summary

  • Architecture-gates workflow has been failing on every PR since refactor(daemon): satisfy daemonapi.Daemon via adapter; complete common extraction #155 merged (the extraction refactor)
  • The workflow runs `go test ./pkg/daemon ./pkg/registry/... ./pkg/secure` but `pkg/registry/` and `pkg/secure/` no longer exist on `main` — they were extracted to `pilot-protocol/rendezvous` and `pilot-protocol/common`
  • Drop the missing paths; keep `./pkg/daemon/...` which is the actual lock-graph surface for the daemon

Failure pattern this fixes

```
go test -race -timeout 5m ./pkg/daemon ./pkg/registry/... ./pkg/secure

./pkg/registry/...

FAIL ./pkg/registry/... [setup failed]
pattern ./pkg/registry/...: lstat ./pkg/registry/: no such file or directory

./pkg/secure

FAIL ./pkg/secure [setup failed]
```

Currently failing this check on `main`: PRs #177, #178, #179, #180.

Test plan

  • `go test -race -timeout 5m ./pkg/daemon/...` runs locally without the missing-directory errors
  • PR's own arch-gates run goes green

PR #155 extracted pkg/registry to pilot-protocol/rendezvous and
pkg/secure to pilot-protocol/common, but the architecture-gates
workflow still ran 'go test ./pkg/registry/... ./pkg/secure',
which now fails with 'no such file or directory' on every PR.

Replace with ./pkg/daemon/... — the daemon-side lock graph
(Store.mu, ReplayMu, SalvageMu, tm.mu) is what this gate is
actually meant to cover. The extracted layers' lock-graph
coverage now runs from their own sibling repos.

Verified locally on ubuntu equivalent: arch-gates command
'go test -race -timeout 5m ./pkg/daemon/...' completes without
the missing-directory errors.

Unblocks PRs #177, #178, #179, #180.
@TeoSlayer TeoSlayer requested a review from Alexgodoroja as a code owner May 30, 2026 00:51
@TeoSlayer TeoSlayer merged commit 6ca5990 into main May 30, 2026
6 checks passed
TeoSlayer added a commit that referenced this pull request May 30, 2026
… tests (#184)

#155 / #182 extracted pkg/beacon to common but missed updating the release
workflow's test target — `stat: pkg/beacon: directory not found` aborted
every release tag push before any binaries got built.

Drop the stale path. Also expand the skip list to cover the integration tests
that have proven flaky on the GH Actions runner network stack
(TestNetworkInviteJoinRule, TestPerNetworkMetrics, TestMetricsRequestCounting,
TestMetricsGauges, TestMultipleListeners, TestIntegration_WebhookDLQWithRealServer
— all rely on loopback HTTP servers that the runner intermittently can't
reach). These tests still run under the broader CI workflow on PRs; the
release gate stays as a smoke check that the test binary compiles and the
fast suite passes.

Co-authored-by: Teodor Calin <teodor@vulturelabs.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants