Skip to content

fix: warn when PILOT_REGISTRY/PILOT_BEACON env vars override compiled defaults (PILOT-236) #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeoSlayer merged 1 commit into from
May 29, 2026
+11 −0
Merged

fix: warn when PILOT_REGISTRY/PILOT_BEACON env vars override compiled defaults (PILOT-236) #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cmd/daemon/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,16 @@ var version = "dev"
func main() {
configPath := flag.String("config", "", "path to config file (JSON)")
registryDefault := "34.71.57.205:9000"
registryFromEnv := false
if v := os.Getenv("PILOT_REGISTRY"); v != "" {
registryDefault = v
registryFromEnv = true
}
beaconDefault := "34.71.57.205:9001"
beaconFromEnv := false
if v := os.Getenv("PILOT_BEACON"); v != "" {
beaconDefault = v
beaconFromEnv = true
}
registryAddr := flag.String("registry", registryDefault, "registry server address (or $PILOT_REGISTRY)")
beaconAddr := flag.String("beacon", beaconDefault, "beacon server address (or $PILOT_BEACON)")
Expand Down Expand Up @@ -138,6 +142,13 @@ func main() {

logging.Setup(*logLevel, *logFormat)

if registryFromEnv {
slog.Warn("PILOT_REGISTRY env var overrides compiled default — registry address redirected to " + *registryAddr + ". If this is unexpected, check the daemon's environment for tampering.")
}
if beaconFromEnv {
slog.Warn("PILOT_BEACON env var overrides compiled default — beacon address redirected to " + *beaconAddr + ". If this is unexpected, check the daemon's environment for tampering.")
}

d := daemon.New(daemon.Config{
RegistryAddr: *registryAddr,
BeaconAddr: *beaconAddr,
Expand Down
Loading