fix: resolve #1120 — UpgradePatch 建议#1797
Open
Nam0101 wants to merge 1 commit into
Open
Conversation
Fixes Tencent#1120 Signed-off-by: Nguyen Van Nam <nam.nv205106@gmail.com>
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: resolve #1120 — UpgradePatch 建议
Problem
Severity:
Low| File:tinker-android/tinker-android-lib-no-op/src/main/java/com/tencent/tinker/lib/patch/UpgradePatch.javaThe no-op variant of
tinker-android-libexposes the sameUpgradePatchAPI surface as the real library. To keep the two artifacts swappable at build time, the sameprotected->publicvisibility promotion must be applied here. If only the real lib is updated, consumers who depend ontinker-android-lib-no-op(typically for release/no-op flavors) would see a different API and lose access to the now-public helpers, which would defeat the purpose of the change.Solution
In
tinker-android/tinker-android-lib-no-op/src/main/java/com/tencent/tinker/lib/patch/UpgradePatch.java, mirror the modifications made in the real lib: changeprotectedtopublicon the same set of recover/merge helper methods (tryRecoverDexFiles,tryRecoverLibraryFiles,tryRecoverResourceFiles, and any otherprotectedhelpers present). Keep the method bodies as-is (they are no-ops in this module). Build the module with./gradlew :tinker-android:tinker-android-lib-no-op:assembleto verify the change compiles cleanly.Changes
tinker-android/tinker-android-lib-no-op/src/main/java/com/tencent/tinker/lib/patch/UpgradePatch.java(modified)Testing
Note: this change was drafted with AI assistance and reviewed locally before submission.