get config values from global object related to issue #69#253
Open
marifehe wants to merge 1 commit intoTemasys:developmentfrom
marifehe:development
Open
get config values from global object related to issue #69#253marifehe wants to merge 1 commit intoTemasys:developmentfrom marifehe:development
marifehe wants to merge 1 commit intoTemasys:developmentfrom
marifehe:development
Conversation
Contributor
|
LGTM. |
Author
|
Actually, I think the way I did it, the real AdapterJS would be available in global scope. What do you think about getting only a copy of the config values with This way the real AdapterJS truly remains local and won't be available in the global scope. |
Author
|
Will it be possible to merge this? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for AdapterJS to be able to pick values that have been set before it is required or imported, otherwise the
var AdapterJS = ...itself is already overwriting whatever was in the global variable.It is interpreted as:
Accessing through window solves the issue.
Does it make sense to you?