Empty password on SMB Dialog#4356
Merged
EmmanuelMess merged 3 commits intoTeamAmaze:release/4.0from Apr 3, 2026
Merged
Conversation
VishnuSanal
added
the
PR-Awaiting-Initial-Review
Member
|
Code looks okay. Will wait for CI to test. |
Member
|
@abdulroufsidhu please run spotless (./gradlew spotlessApply`) |
Member
|
any updates here @abdulroufsidhu, thanks! |
Contributor
Author
appologies for the delay It's done. Thanks for the patience and cooperation. |
Contributor
Author
|
@EmmanuelMess shall I push 4353 fix as well with this ? |
Member
Not to this branch. |
EmmanuelMess
approved these changes
Apr 3, 2026
Member
EmmanuelMess
left a comment
EmmanuelMess
left a comment
There was a problem hiding this comment.
Tested with docker -it -e NAME="Data" -e USER="samba" -e PASS="" -p 445:445 run dockurr/samba on emulator, and it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue tracker
Fixes #4354
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck