Skip to content

Move mock types into xbot.common from edu.wpi.first.wpilibj - #676

Open
stephenjust wants to merge 1 commit into
mainfrom
clean-namespaces
Open

Move mock types into xbot.common from edu.wpi.first.wpilibj#676
stephenjust wants to merge 1 commit into
mainfrom
clean-namespaces

Conversation

@stephenjust

Copy link
Copy Markdown
Contributor

WPILib 2027 is changing their package name from edu.wpi.first.wpilibj to org.wpilib so now is a good opportunity to clean this up.

WPILib 2027 is changing their package name from `edu.wpi.first.wpilibj` to `org.wpilib` so now is a good opportunity to clean this up.
Copilot AI review requested due to automatic review settings July 30, 2026 02:57
@stephenjust
stephenjust requested a review from a team as a code owner July 30, 2026 02:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relocates several mock/stub implementations that previously lived in the edu.wpi.first.wpilibj namespace into xbot.common.*, reducing coupling to WPILib’s package layout ahead of the upcoming WPILib package rename.

Changes:

  • Updated unit tests and test harness base classes to import mock types from xbot.common.controls.*.mock_adapters.
  • Updated Dagger modules (MockDevicesModule, MockControlsModule, UnitTestModule) to bind factories and implementations from the new mock packages.
  • Repackaged multiple mock adapter classes by changing their package declarations to match their xbot.common source tree locations.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/test/java/xbot/common/subsystems/pose/BasePoseTest.java Switches MockTimer import to new mock adapter package.
src/test/java/xbot/common/subsystems/feedback/RumbleManagerTest.java Switches MockTimer import to new mock adapter package.
src/test/java/xbot/common/subsystems/drive/HeadingModuleTest.java Switches MockTimer import to new mock adapter package.
src/test/java/xbot/common/subsystems/drive/HeadingAssistModuleTest.java Switches MockTimer import to new mock adapter package.
src/test/java/xbot/common/simulation/SimulatedTimerTest.java Switches MockTimer import to new mock adapter package.
src/test/java/xbot/common/simulation/SimulatedSolenoidTest.java Switches MockSolenoid import to new mock adapter package.
src/test/java/xbot/common/math/PIDManagerTest.java Switches MockTimer import to new mock adapter package.
src/test/java/xbot/common/injection/MockTimerTest.java Switches MockTimer import to new mock adapter package.
src/test/java/xbot/common/controls/sensors/XboxControllerTest.java Switches MockXboxControllerAdapter import to new mock adapter package.
src/test/java/xbot/common/controls/actuators/XDoubleSolenoidTest.java Switches MockSolenoid import to new mock adapter package.
src/test/java/xbot/common/controls/actuators/TimedAndBoundedServoTest.java Switches MockTimer import to new mock adapter package.
src/main/java/xbot/common/simulation/BaseSimulationTest.java Switches MockTimer import to new mock adapter package.
src/main/java/xbot/common/injection/modules/UnitTestModule.java Binds timer implementations using the relocated MockTimer.
src/main/java/xbot/common/injection/modules/MockDevicesModule.java Updates imports/bindings to use relocated mock device factories.
src/main/java/xbot/common/injection/modules/MockControlsModule.java Updates imports/bindings to use relocated mock controller factory.
src/main/java/xbot/common/injection/BaseWPITest.java Switches MockTimer import to new mock adapter package.
src/main/java/xbot/common/controls/sensors/mock_adapters/MockXboxControllerAdapter.java Changes package to xbot.common... and adds required WPILib imports.
src/main/java/xbot/common/controls/sensors/mock_adapters/MockTimer.java Changes package to xbot.common....
src/main/java/xbot/common/controls/sensors/mock_adapters/MockLidarLite.java Changes package to xbot.common....
src/main/java/xbot/common/controls/sensors/mock_adapters/MockDutyCycleEncoder.java Removes old WPILib mock import as part of repackaging.
src/main/java/xbot/common/controls/sensors/mock_adapters/MockDistanceSensorPair.java Changes package to xbot.common....
src/main/java/xbot/common/controls/sensors/mock_adapters/MockDistanceSensor.java Changes package to xbot.common....
src/main/java/xbot/common/controls/sensors/mock_adapters/MockDigitalInput.java Changes package to xbot.common....
src/main/java/xbot/common/controls/sensors/mock_adapters/MockAnalogInput.java Changes package to xbot.common....
src/main/java/xbot/common/controls/actuators/mock_adapters/MockSpeedController.java Changes package to xbot.common....
src/main/java/xbot/common/controls/actuators/mock_adapters/MockSolenoid.java Changes package to xbot.common....
src/main/java/xbot/common/controls/actuators/mock_adapters/MockServo.java Changes package to xbot.common....
src/main/java/xbot/common/controls/actuators/mock_adapters/MockPWM.java Changes package to xbot.common....
src/main/java/xbot/common/controls/actuators/mock_adapters/MockDigitalOutput.java Changes package to xbot.common....
Comments suppressed due to low confidence (1)

src/main/java/xbot/common/controls/sensors/mock_adapters/MockDutyCycleEncoder.java:10

  • Unused import xbot.common.controls.sensors.XAnalogInput remains after moving mocks; this will likely fail Checkstyle's unused imports rule and adds noise.
import xbot.common.command.DataFrameRegistry;
import xbot.common.controls.io_inputs.XDutyCycleEncoderInputs;
import xbot.common.controls.sensors.XAnalogInput;
import xbot.common.controls.sensors.XDutyCycleEncoder;
import xbot.common.injection.DevicePolice;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants