Skip to content

[FIX] 홈·설정 약관 페이지 하단 여백 QA 반영 #235

Merged
kimminna merged 2 commits into
developfrom
fix/web/234-home-settings-padding-qa
Jul 16, 2026
Merged

[FIX] 홈·설정 약관 페이지 하단 여백 QA 반영 #235
kimminna merged 2 commits into
developfrom
fix/web/234-home-settings-padding-qa

Conversation

@ehye1

@ehye1 ehye1 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

ISSUE 🔗

close #234



What is this PR? 🔍

  • overflow-x-auto 컨테이너에 pb를 적용해도 overflow-y 클립으로 인해 여백이 노출되지 않는 문제 수정 → 상위 <section>pb-3 적용
  • 홈 스크롤 컨테이너 내부의 pb-2 제거 (클립되어 적용 불가)
  • 설정 약관 페이지(SettingsTermsContainer) 하단에 pb-12.5 추가



To Reviewers

overflow-x: auto를 적용하면 암묵적으로 overflow-y: hidden이 설정되어 자식 요소의 padding-bottom이 클립됩니다. 이로 인해 스크롤 컨테이너 내부에 pb를 넣어도 여백이 보이지 않아 상위 요소로 이동했습니다.



Screenshot 📷



Test Checklist ✔

  • 홈 탭 스크롤 시 카드 하단 여백 노출 확인
  • 설정 약관 페이지 하단 여백 확인

- overflow-x-auto 컨테이너의 pb 클립 이슈로 인해 상위 section에 pb-3 적용
- 스크롤 컨테이너 내부의 pb-2 제거
- 설정 약관 페이지 하단에 pb-12.5 추가

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
timo Ready Ready Preview, Comment Jul 16, 2026 3:15am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kimminna, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1f84ed7a-339d-481c-9c9e-95186475f4ca

📥 Commits

Reviewing files that changed from the base of the PR and between 43fc72e and a0a86b8.

📒 Files selected for processing (3)
  • apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/home/_containers/HomeTodoContainer.tsx
  • apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/home/page.tsx
  • apps/timo-web/app/[locale]/(main)/settings/_containers/terms/SettingsTermsContainer.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/web/234-home-settings-padding-qa

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot requested review from jjangminii and kimminna July 15, 2026 13:42
@github-actions github-actions Bot added the ⏰ Timo-web Timo 웹 서비스 label Jul 15, 2026
@github-actions github-actions Bot added the ♥️ 혜원 혜원양 label Jul 15, 2026
@ehye1 ehye1 changed the title fix(web): 홈·설정 약관 페이지 하단 여백 QA 반영 (#234) [FIX] 홈·설정 약관 페이지 하단 여백 QA 반영 Jul 15, 2026
@github-actions github-actions Bot added the 🐛 Bug 기능이 정상적으로 작동하지 않는 문제 수정 label Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

Timo Performance Report

Bundle Size — timo-web
라우트 크기 First Load JS
/[locale]/home 211.39 kB 🔴 417.25 kB
/[locale]/today 195.60 kB 🔴 401.46 kB
/[locale]/focus 160.64 kB 🔴 366.50 kB
/[locale]/settings 167.19 kB 🔴 373.05 kB
/[locale]/statistics 233.45 kB 🔴 439.31 kB
/[locale]/[...rest] 0 B 🟡 205.86 kB
/[locale]/login 212.96 kB 🔴 418.82 kB
/[locale]/oauth/callback 119.66 kB 🟡 325.52 kB
/[locale]/onboarding 233.44 kB 🔴 439.30 kB
/[locale] 118.97 kB 🟡 324.83 kB
/[locale]/policy 125.09 kB 🟡 330.95 kB

공유 번들: 205.86 kB
🟢 < 200kB  |  🟡 < 350kB  |  🔴 ≥ 350kB (First Load JS · gzip)

Lighthouse — timo-web
URL Perf A11y LCP CLS TBT
/en/home 🔴 59 🟢 95 🔴 15.8s 🟢 0.000 🟡 589ms
/en/today 🔴 63 🟢 95 🔴 15.5s 🟢 0.000 🟡 465ms
/en/focus 🔴 59 🟢 95 🔴 15.3s 🟢 0.000 🔴 613ms
/en/statistics 🔴 61 🟢 95 🔴 15.0s 🟢 0.000 🟡 524ms

Perf ≥ 70 / A11y ≥ 85 목표
LCP 🟢 < 2.5s 🟡 < 4s 🔴 ≥ 4s  |  CLS 🟢 < 0.1 🟡 < 0.25 🔴 ≥ 0.25  |  TBT 🟢 < 200ms 🟡 < 600ms 🔴 ≥ 600ms

Image Optimization — timo-web
파일 크기 포맷 상태
favicon.png 27.84 kB PNG ⚠️ 🟢
images/google-calendar.png 36.20 kB PNG ⚠️ 🟢
images/google-logo.png 26.79 kB PNG ⚠️ 🟢

총 3개 · 90.84 kB  |  🟢 < 200KB  |  🟡 < 500KB  |  🔴 ≥ 500KB
⚠️ 3개 파일 WebP/AVIF 변환 권장

측정 커밋: 18a8cd3

@ehye1 ehye1 added the 🚬 QA QA 반영 label Jul 15, 2026

@kimminna kimminna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@jjangminii jjangminii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

체크아웃해서 확인했습니다~~

@kimminna kimminna merged commit 166aebb into develop Jul 16, 2026
12 checks passed
@kimminna kimminna deleted the fix/web/234-home-settings-padding-qa branch July 16, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♥️ 혜원 혜원양 🐛 Bug 기능이 정상적으로 작동하지 않는 문제 수정 🚬 QA QA 반영 ⏰ Timo-web Timo 웹 서비스

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] 홈·설정 약관 페이지 하단 여백 QA 반영

3 participants