Skip to content

[FIX] Today 페이지 QA 반영#232

Merged
kimminna merged 2 commits into
developfrom
fix/web/231-today-page-qa
Jul 16, 2026
Merged

[FIX] Today 페이지 QA 반영#232
kimminna merged 2 commits into
developfrom
fix/web/231-today-page-qa

Conversation

@ehye1

@ehye1 ehye1 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

ISSUE 🔗

close #231



What is this PR? 🔍

Today 탭 투두 카드의 날짜 형식 오류와 툴바 삭제 아이콘 노출 문제를 수정했습니다.

배경

  • 기존 구조: 날짜를 M/D 형식으로 변환하는 formatDate 유틸을 사용했고, 카드 툴바에 휴지통 아이콘이 항상 렌더링됐습니다.
  • 발생 문제: 날짜가 7/15로 표시되어 연도 정보가 없었고, 삭제 동작이 상세 모달에서만 지원됨에도 카드에 삭제 아이콘이 노출됐습니다.
  • 해결 방향: 날짜 포맷을 yy.MM.dd로 교체하고, 카드 툴바에서 휴지통 아이콘을 제거했습니다.

날짜 형식

  • 변경 요약: formatDateformatShortDateLabel로 교체했습니다.
  • 이유: formatDateM/D 형식을 반환해 연도가 누락됩니다.
  • 구현 방식: TodayTodoListContainer에서 formatShortDateLabel(new Date(todo.date))로 변경해 YY.MM.DD 형식으로 표시합니다. formatShortDateLabel은 기존 유틸에 이미 정의되어 있습니다.

카드 툴바 삭제 아이콘

  • 변경 요약: TodayTodoCard에서 휴지통 아이콘 렌더링을 제거했습니다.
  • 이유: 삭제는 상세 모달에서만 가능하며 카드에 아이콘이 노출되면 사용자에게 혼란을 줍니다.
  • 경계 · 제약: 상세 모달(DetailTodoModalContainer)의 삭제 기능은 변경하지 않았습니다.



To Reviewers

날짜 형식 변경이 Today 탭에만 적용됩니다. Home 탭은 별도 포맷을 사용하므로 영향 없습니다.



Screenshot 📷



Test Checklist ✔

  • lint-staged 통과
  • 타입 체크 통과
  • Today 탭 투두 카드 날짜 26.07.15 형식 확인
  • Today 탭 투두 카드 툴바에 휴지통 아이콘 미노출 확인
  • 상세 모달에서 삭제 기능 정상 동작 확인

- 투두 카드 날짜 형식을 M/D에서 YY.MM.DD로 변경했습니다
- 투두 카드 툴바에서 휴지통 아이콘을 제거했습니다
@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
timo Ready Ready Preview, Comment Jul 15, 2026 1:18pm

Request Review

@github-actions github-actions Bot requested review from jjangminii and kimminna July 15, 2026 12:56
@github-actions github-actions Bot added ⏰ Timo-web Timo 웹 서비스 🐛 Bug 기능이 정상적으로 작동하지 않는 문제 수정 ♥️ 혜원 혜원양 labels Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ehye1, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f1348e9d-d8a4-4088-b89e-aceb64572056

📥 Commits

Reviewing files that changed from the base of the PR and between f686f2d and 2fea3cc.

📒 Files selected for processing (1)
  • apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/today/_containers/TodayTodoListContainer.tsx

Walkthrough

Today 투두 카드에서 툴바의 휴지통 아이콘을 제거하고, 날짜 표시를 YY.MM.DD 형식에 맞는 short date label 포맷으로 변경합니다.

Changes

Today 페이지 QA 수정

Layer / File(s) Summary
툴바 휴지통 아이콘 제거
apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/today/_components/TodayTodoCard.tsx
상태에 따른 휴지통 아이콘 조건부 렌더링과 관련 아이콘 import를 제거합니다.
툴바 날짜 포맷 변경
apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/today/_containers/TodayTodoListContainer.tsx
투두 카드 툴바 날짜를 formatShortDateLabel(new Date(todo.date))로 생성합니다.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: jjangminii, kimminna, yumin-kim2

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 제목이 Today 탭 QA 수정이라는 핵심 변경을 잘 요약해 관련성이 높습니다.
Description check ✅ Passed 설명이 날짜 포맷 수정과 툴바 휴지통 아이콘 제거를 명확히 담아 변경 내용과 잘 맞습니다.
Linked Issues check ✅ Passed 직접 이슈 #231의 날짜 형식 변경과 삭제 아이콘 숨김 요구를 모두 반영했습니다.
Out of Scope Changes check ✅ Passed 요구사항 외 변경은 보이지 않고 Today 카드/리스트 범위 안에서만 수정됐습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/web/231-today-page-qa

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

Timo Performance Report

Bundle Size — timo-web
라우트 크기 First Load JS
/[locale]/home 210.07 kB 🔴 415.93 kB
/[locale]/today 194.17 kB 🔴 400.02 kB
/[locale]/focus 160.01 kB 🔴 365.87 kB
/[locale]/settings 166.55 kB 🔴 372.41 kB
/[locale]/statistics 232.87 kB 🔴 438.72 kB
/[locale]/[...rest] 0 B 🟡 205.86 kB
/[locale]/login 212.95 kB 🔴 418.80 kB
/[locale]/oauth/callback 119.64 kB 🟡 325.50 kB
/[locale]/onboarding 232.85 kB 🔴 438.71 kB
/[locale] 118.95 kB 🟡 324.81 kB
/[locale]/policy 125.08 kB 🟡 330.93 kB

공유 번들: 205.86 kB
🟢 < 200kB  |  🟡 < 350kB  |  🔴 ≥ 350kB (First Load JS · gzip)

Lighthouse — timo-web
URL Perf A11y LCP CLS TBT
/en/home 🔴 58 🟢 95 🔴 15.6s 🟢 0.000 🔴 639ms
/en/today 🔴 64 🟢 95 🔴 15.6s 🟢 0.000 🟡 439ms
/en/focus 🔴 59 🟢 95 🔴 15.3s 🟢 0.000 🔴 620ms
/en/statistics 🔴 61 🟢 95 🔴 15.2s 🟢 0.000 🟡 512ms

Perf ≥ 70 / A11y ≥ 85 목표
LCP 🟢 < 2.5s 🟡 < 4s 🔴 ≥ 4s  |  CLS 🟢 < 0.1 🟡 < 0.25 🔴 ≥ 0.25  |  TBT 🟢 < 200ms 🟡 < 600ms 🔴 ≥ 600ms

Image Optimization — timo-web
파일 크기 포맷 상태
favicon.png 27.84 kB PNG ⚠️ 🟢
images/google-calendar.png 36.20 kB PNG ⚠️ 🟢
images/google-logo.png 26.79 kB PNG ⚠️ 🟢

총 3개 · 90.84 kB  |  🟢 < 200KB  |  🟡 < 500KB  |  🔴 ≥ 500KB
⚠️ 3개 파일 WebP/AVIF 변환 권장

측정 커밋: a83da1e

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@apps/timo-web/app/`[locale]/(main)/(with-time-sidebar)/today/_containers/TodayTodoListContainer.tsx:
- Around line 119-120: Update the todo date handling in TodayTodoListContainer
to parse the yyyy-MM-dd key with parseDateKey(todo.date) ?? new Date() instead
of constructing new Date(todo.date) directly. Reuse the resulting parsed Date
for both formatShortDateLabel and dateValue, matching DetailTodoModalContainer’s
date interpretation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f11485b6-9f2e-48c0-9d20-6505836d6ecd

📥 Commits

Reviewing files that changed from the base of the PR and between 590c15d and f686f2d.

📒 Files selected for processing (2)
  • apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/today/_components/TodayTodoCard.tsx
  • apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/today/_containers/TodayTodoListContainer.tsx
💤 Files with no reviewable changes (1)
  • apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/today/_components/TodayTodoCard.tsx

- new Date(todo.date)는 UTC 기준으로 해석되어 KST에서 하루 밀리는 버그가 있었습니다
- parseDateKey를 사용해 로컬 시간 기준으로 파싱하도록 수정했습니다

@kimminna kimminna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 사항 확인했습니다!

@kimminna kimminna merged commit 43fc72e into develop Jul 16, 2026
11 checks passed
@kimminna kimminna deleted the fix/web/231-today-page-qa branch July 16, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♥️ 혜원 혜원양 🐛 Bug 기능이 정상적으로 작동하지 않는 문제 수정 🚬 QA QA 반영 ⏰ Timo-web Timo 웹 서비스

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] Today 페이지 QA 반영

2 participants