[FIX] Today 페이지 QA 반영#232
Conversation
- 투두 카드 날짜 형식을 M/D에서 YY.MM.DD로 변경했습니다 - 투두 카드 툴바에서 휴지통 아이콘을 제거했습니다
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughToday 투두 카드에서 툴바의 휴지통 아이콘을 제거하고, 날짜 표시를 ChangesToday 페이지 QA 수정
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Timo Performance ReportBundle Size — timo-web
Lighthouse — timo-web
Image Optimization — timo-web
측정 커밋: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@apps/timo-web/app/`[locale]/(main)/(with-time-sidebar)/today/_containers/TodayTodoListContainer.tsx:
- Around line 119-120: Update the todo date handling in TodayTodoListContainer
to parse the yyyy-MM-dd key with parseDateKey(todo.date) ?? new Date() instead
of constructing new Date(todo.date) directly. Reuse the resulting parsed Date
for both formatShortDateLabel and dateValue, matching DetailTodoModalContainer’s
date interpretation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f11485b6-9f2e-48c0-9d20-6505836d6ecd
📒 Files selected for processing (2)
apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/today/_components/TodayTodoCard.tsxapps/timo-web/app/[locale]/(main)/(with-time-sidebar)/today/_containers/TodayTodoListContainer.tsx
💤 Files with no reviewable changes (1)
- apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/today/_components/TodayTodoCard.tsx
- new Date(todo.date)는 UTC 기준으로 해석되어 KST에서 하루 밀리는 버그가 있었습니다 - parseDateKey를 사용해 로컬 시간 기준으로 파싱하도록 수정했습니다
ISSUE 🔗
close #231
What is this PR? 🔍
Today 탭 투두 카드의 날짜 형식 오류와 툴바 삭제 아이콘 노출 문제를 수정했습니다.
배경
M/D형식으로 변환하는formatDate유틸을 사용했고, 카드 툴바에 휴지통 아이콘이 항상 렌더링됐습니다.7/15로 표시되어 연도 정보가 없었고, 삭제 동작이 상세 모달에서만 지원됨에도 카드에 삭제 아이콘이 노출됐습니다.yy.MM.dd로 교체하고, 카드 툴바에서 휴지통 아이콘을 제거했습니다.날짜 형식
formatDate→formatShortDateLabel로 교체했습니다.formatDate는M/D형식을 반환해 연도가 누락됩니다.TodayTodoListContainer에서formatShortDateLabel(new Date(todo.date))로 변경해YY.MM.DD형식으로 표시합니다.formatShortDateLabel은 기존 유틸에 이미 정의되어 있습니다.카드 툴바 삭제 아이콘
TodayTodoCard에서 휴지통 아이콘 렌더링을 제거했습니다.DetailTodoModalContainer)의 삭제 기능은 변경하지 않았습니다.To Reviewers
날짜 형식 변경이 Today 탭에만 적용됩니다. Home 탭은 별도 포맷을 사용하므로 영향 없습니다.
Screenshot 📷
Test Checklist ✔
26.07.15형식 확인