Skip to content

[FIX] 온보딩/로그인 페이지 QA 반영#229

Merged
kimminna merged 1 commit into
developfrom
fix/web/228-onboarding-login-qa
Jul 16, 2026
Merged

[FIX] 온보딩/로그인 페이지 QA 반영#229
kimminna merged 1 commit into
developfrom
fix/web/228-onboarding-login-qa

Conversation

@ehye1

@ehye1 ehye1 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

ISSUE 🔗

close #228



What is this PR? 🔍

온보딩 및 로그인 페이지 QA에서 발견된 레이아웃 문제 두 가지를 수정했습니다.

배경

  • 기존 구조: 온보딩 카드 박스에 너비 고정 없이 min-h만 지정되어 있었고, 로그인 약관 문구에 줄바꿈이 빠져 있었습니다.
  • 발생 문제: 박스 크기가 콘텐츠에 따라 유동적으로 변하고, 약관 텍스트가 한 줄로 이어져 표시됐습니다.
  • 해결 방향: 박스를 w-108 h-153.5로 고정하고, 약관 문구에 줄바꿈을 추가했습니다.

온보딩 카드 박스

  • 변경 요약: min-h-153.5h-153.5 w-108로 변경해 크기를 고정했습니다.
  • 이유: 스텝별 콘텐츠 높이 차이로 박스 크기가 달라지는 문제가 있었습니다.
  • 구현 방식: 내부 레이아웃은 flex-1로 남은 공간을 채우는 구조라 고정 크기를 줘도 기존 레이아웃이 유지됩니다.

로그인 약관 문구

  • 변경 요약: en.jsontermsNotice 문자열에 \n 줄바꿈을 추가했습니다.
  • 이유: "Terms of Service and Privacy Policy" 앞에서 줄이 바뀌어야 하는데 한 줄로 이어지고 있었습니다.



To Reviewers

변경이 단순해 별도로 집중해서 볼 지점은 없습니다.



Screenshot 📷



Test Checklist ✔

  • lint-staged 통과
  • 온보딩 각 스텝에서 카드 박스 크기 고정 확인
  • 로그인 페이지 약관 문구 줄바꿈 확인

- 온보딩 박스 크기를 w-108, h-153.5로 고정했습니다
- 로그인 페이지 약관 문구의 줄바꿈을 수정했습니다
@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
timo Ready Ready Preview, Comment Jul 15, 2026 12:40pm

Request Review

@github-actions
github-actions Bot requested review from kimminna and yumin-kim2 July 15, 2026 12:39
@github-actions github-actions Bot added ⏰ Timo-web Timo 웹 서비스 🐛 Bug 기능이 정상적으로 작동하지 않는 문제 수정 ♥️ 혜원 혜원양 labels Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ehye1, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 19ee97cc-4e51-4813-a716-bec0259413cf

📥 Commits

Reviewing files that changed from the base of the PR and between 590c15d and 1219b40.

📒 Files selected for processing (2)
  • apps/timo-web/app/[locale]/onboarding/_containers/OnboardingFunnelContainer.tsx
  • apps/timo-web/messages/en.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Timo Performance Report

Bundle Size — timo-web
라우트 크기 First Load JS
/[locale]/home 210.11 kB 🔴 415.97 kB
/[locale]/today 194.23 kB 🔴 400.09 kB
/[locale]/focus 160.03 kB 🔴 365.89 kB
/[locale]/settings 166.58 kB 🔴 372.43 kB
/[locale]/statistics 232.90 kB 🔴 438.76 kB
/[locale]/[...rest] 0 B 🟡 205.86 kB
/[locale]/login 212.95 kB 🔴 418.80 kB
/[locale]/oauth/callback 119.64 kB 🟡 325.50 kB
/[locale]/onboarding 232.88 kB 🔴 438.74 kB
/[locale] 118.95 kB 🟡 324.81 kB
/[locale]/policy 125.08 kB 🟡 330.93 kB

공유 번들: 205.86 kB
🟢 < 200kB  |  🟡 < 350kB  |  🔴 ≥ 350kB (First Load JS · gzip)

Lighthouse — timo-web
URL Perf A11y LCP CLS TBT
/en/home 🔴 63 🟢 95 🔴 15.7s 🟢 0.000 🟡 462ms
/en/today 🔴 60 🟢 95 🔴 15.6s 🟢 0.000 🟡 572ms
/en/focus 🔴 69 🟢 95 🔴 15.2s 🟢 0.000 🟡 274ms
/en/statistics 🔴 61 🟢 95 🔴 15.2s 🟢 0.000 🟡 538ms

Perf ≥ 70 / A11y ≥ 85 목표
LCP 🟢 < 2.5s 🟡 < 4s 🔴 ≥ 4s  |  CLS 🟢 < 0.1 🟡 < 0.25 🔴 ≥ 0.25  |  TBT 🟢 < 200ms 🟡 < 600ms 🔴 ≥ 600ms

Image Optimization — timo-web
파일 크기 포맷 상태
favicon.png 27.84 kB PNG ⚠️ 🟢
images/google-calendar.png 36.20 kB PNG ⚠️ 🟢
images/google-logo.png 26.79 kB PNG ⚠️ 🟢

총 3개 · 90.84 kB  |  🟢 < 200KB  |  🟡 < 500KB  |  🔴 ≥ 500KB
⚠️ 3개 파일 WebP/AVIF 변환 권장

측정 커밋: c804094

@ehye1 ehye1 added the 🚬 QA QA 반영 label Jul 15, 2026

@kimminna kimminna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경된 부분 확인했습니다!

@kimminna
kimminna merged commit 1b1600a into develop Jul 16, 2026
13 checks passed
@kimminna
kimminna deleted the fix/web/228-onboarding-login-qa branch July 16, 2026 02:59
@kimminna kimminna mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♥️ 혜원 혜원양 🐛 Bug 기능이 정상적으로 작동하지 않는 문제 수정 🚬 QA QA 반영 ⏰ Timo-web Timo 웹 서비스

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] 온보딩/로그인 페이지 QA 반영

2 participants