fix: Migrate secret_value column to be TEXT#189
Open
yuechao-qin wants to merge 1 commit intomasterfrom
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yuechao-qin
force-pushed
the
ycq/fix-migrate-secret-to-text
branch
from
7438c21 to
9feb053
Compare
yuechao-qin
force-pushed
the
ycq/fix-migrate-secret-to-text
branch
from
9feb053 to
e0ac2d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Changed the
secret_valuecolumn in the Secret table from VARCHAR to TEXT type to support longer secret values, with a database migration to handle existing deployments.What changed?
Secretmodel'ssecret_valuefield to usesql.Text()instead of the default string typemigrate_secret_value_column()function that performs dialect-aware column type migration for MySQL, PostgreSQL, and SQLitemigrate_db()function to run automatically during database migrationsHow to test?
Why make this change?
The previous VARCHAR column type had length limitations that could prevent storing longer secret values. Using TEXT type removes these constraints while maintaining compatibility across different database dialects. The migration ensures existing deployments can upgrade seamlessly without manual intervention.