Skip to content

fix: Add separate GCS key Env for local dev #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camielvs wants to merge 1 commit into
base: master
Choose a base branch
from
+23 −8
Open

fix: Add separate GCS key Env for local dev #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions cloud_pipelines_backend/api_server_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,15 +1051,30 @@ def get_signed_artifact_url(
f"The get_signed_artifact_url method only supports Google Cloud Storage URIs, but got {artifact_data.uri=}."
)

import os
from google.cloud import storage
from google import auth

# Avoiding error: "you need a private key to sign credentials."
# "the credentials you are currently using <class 'google.auth.compute_engine.credentials.Credentials'> just contains a token.
# "see https://googleapis.dev/python/google-api-core/latest/auth.html#setting-up-a-service-account for more details."
credentials = auth.default(
scopes=["https://www.googleapis.com/auth/cloud-platform.read-only"]
)[0]

# On GKE/Cloud Run the default SA credentials already have a private key.
# Locally, ADC is typically an OAuth user token (no private key), so we allow
# pointing GCS_SIGNING_KEY_FILE at a service account JSON key file to use instead.
sa_key_file = os.environ.get("GCS_SIGNING_KEY_FILE")
if sa_key_file:
from google.oauth2 import service_account

credentials = service_account.Credentials.from_service_account_file(
sa_key_file,
scopes=["https://www.googleapis.com/auth/cloud-platform"],
)
else:
from google import auth

# Avoiding error: "you need a private key to sign credentials."
# "the credentials you are currently using <class 'google.auth.compute_engine.credentials.Credentials'> just contains a token.
# "see https://googleapis.dev/python/google-api-core/latest/auth.html#setting-up-a-service-account for more details."
credentials = auth.default(
scopes=["https://www.googleapis.com/auth/cloud-platform"]
)[0]

storage_client = storage.Client(credentials=credentials)
blob = storage.Blob.from_string(uri=artifact_data.uri, client=storage_client)
signed_url = blob.generate_signed_url(
Expand Down
Loading