Skip to content

update favourite and recent cards #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mbeaulne wants to merge 1 commit into
base: 03-24-updates_revently_viewed
Choose a base branch
from
+39 −46
Draft

update favourite and recent cards #2001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 21 additions & 23 deletions src/routes/Dashboard/DashboardFavoritesView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useNavigate } from "@tanstack/react-router";
import { Link } from "@tanstack/react-router";
import { ChevronLeft, ChevronRight, GitBranch, Play, X } from "lucide-react";
import { useState } from "react";

Expand All @@ -18,23 +18,19 @@ function getFavoriteUrl(item: FavoriteItem): string {
}

const FavoriteCard = ({ item }: { item: FavoriteItem }) => {
const navigate = useNavigate();
const { removeFavorite } = useFavorites();

const isPipeline = item.type === "pipeline";

return (
<div
onClick={() => navigate({ to: getFavoriteUrl(item) })}
className={`group relative flex flex-col gap-2 p-3 border rounded-lg cursor-pointer transition-colors ${
isPipeline
? "bg-violet-50/40 hover:bg-violet-50 border-violet-100"
: "bg-emerald-50/40 hover:bg-emerald-50 border-emerald-100"
}`}
<Link
to={getFavoriteUrl(item)}
className="group relative flex flex-col gap-2.5 p-3 rounded-lg transition-all shadow-sm hover:shadow-md bg-card border border-border hover:border-foreground/20 no-underline"
>
{/* Remove button */}
<button
onClick={(e) => {
e.preventDefault();
e.stopPropagation();
removeFavorite(item.type, item.id);
}}
Expand All @@ -44,21 +40,23 @@ const FavoriteCard = ({ item }: { item: FavoriteItem }) => {
<X className="h-3.5 w-3.5" />
</button>

{/* Type badge */}
<InlineStack gap="1" blockAlign="center">
{isPipeline ? (
<GitBranch className="h-3.5 w-3.5 shrink-0 text-violet-500" />
) : (
<Play className="h-3.5 w-3.5 shrink-0 text-emerald-500" />
)}
<Text
size="xs"
weight="semibold"
className={isPipeline ? "text-violet-600" : "text-emerald-600"}
{/* Type pill */}
<div className="flex">
<span
className={`inline-flex items-center gap-1 px-1.5 py-0.5 rounded-full text-xs font-semibold ${
isPipeline
? "bg-violet-100 text-violet-700"
: "bg-emerald-100 text-emerald-700"
}`}
>
{isPipeline ? (
<GitBranch className="h-3 w-3" />
) : (
<Play className="h-3 w-3" />
)}
{isPipeline ? "Pipeline" : "Run"}
</Text>
</InlineStack>
</span>
</div>

{/* Name */}
<Text size="sm" weight="semibold" className="truncate pr-4 leading-tight">
Expand All @@ -69,7 +67,7 @@ const FavoriteCard = ({ item }: { item: FavoriteItem }) => {
<Text size="xs" className="truncate text-muted-foreground font-mono">
{item.id}
</Text>
</div>
</Link>
);
};

Expand Down
41 changes: 18 additions & 23 deletions src/routes/Dashboard/DashboardRecentlyViewedView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useNavigate } from "@tanstack/react-router";
import { Link } from "@tanstack/react-router";
import { GitBranch, Play } from "lucide-react";

import { BlockStack, InlineStack } from "@/components/ui/layout";
Expand Down Expand Up @@ -27,34 +27,29 @@ function formatRelativeTime(viewedAt: number): string {
}

const RecentlyViewedCard = ({ item }: { item: RecentlyViewedItem }) => {
const navigate = useNavigate();
const isPipeline = item.type === "pipeline";

return (
<div
onClick={() => navigate({ to: getRecentlyViewedUrl(item) })}
className={`flex flex-col gap-2 p-3 border rounded-lg cursor-pointer transition-colors ${
isPipeline
? "bg-violet-50/40 hover:bg-violet-50 border-violet-100"
: "bg-emerald-50/40 hover:bg-emerald-50 border-emerald-100"
}`}
<Link
to={getRecentlyViewedUrl(item)}
className="flex flex-col gap-2.5 p-3 rounded-lg transition-all shadow-sm hover:shadow-md bg-card border border-border hover:border-foreground/20 no-underline"
>
{/* Type badge */}
<InlineStack gap="1" blockAlign="center" align="space-between">
<InlineStack gap="1" blockAlign="center">
{/* Type pill + timestamp */}
<InlineStack blockAlign="center" align="space-between">
<span
className={`inline-flex items-center gap-1 px-1.5 py-0.5 rounded-full text-xs font-semibold ${
isPipeline
? "bg-violet-100 text-violet-700"
: "bg-emerald-100 text-emerald-700"
}`}
>
{isPipeline ? (
<GitBranch className="h-3.5 w-3.5 shrink-0 text-violet-500" />
<GitBranch className="h-3 w-3" />
) : (
<Play className="h-3.5 w-3.5 shrink-0 text-emerald-500" />
<Play className="h-3 w-3" />
)}
<Text
size="xs"
weight="semibold"
className={isPipeline ? "text-violet-600" : "text-emerald-600"}
>
{isPipeline ? "Pipeline" : "Run"}
</Text>
</InlineStack>
{isPipeline ? "Pipeline" : "Run"}
</span>
<Text size="xs" className="text-muted-foreground">
{formatRelativeTime(item.viewedAt)}
</Text>
Expand All @@ -69,7 +64,7 @@ const RecentlyViewedCard = ({ item }: { item: RecentlyViewedItem }) => {
<Text size="xs" className="truncate text-muted-foreground font-mono">
{item.id}
</Text>
</div>
</Link>
);
};

Expand Down
Loading