Add SOCIAL_DEFAULT_ACCESS support back in#4351
Closed
mattinx wants to merge 1 commit intoTandoorRecipes:developfrom
Closed
Add SOCIAL_DEFAULT_ACCESS support back in#4351mattinx wants to merge 1 commit intoTandoorRecipes:developfrom
mattinx wants to merge 1 commit intoTandoorRecipes:developfrom
Conversation
Move code to handle SOCIAL_DEFAULT_ACCESS and SOCIAL_DEFAULT_GROUP settings into helper functions to restore functionality removed by commit 723b745 No change has been made to the logic of these settings - when SOCIAL_DEFAULT_ACCESS is enabled, users are added to the first space with the group specified by SOCIAL_DEFAULT_GROUP. Further scope for enhancement would be to parse SOCIAL_DEFAULT_ACCESS as an integer (as indicated by the documentation) and use this as the space ID, rather than using Space.objects.first(). Another potential enhancement would be to check space membership on every login, and add the user to the configured space if they are not currently a member.
|
|
Collaborator
|
thank you, I would accept |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move code to handle SOCIAL_DEFAULT_ACCESS and SOCIAL_DEFAULT_GROUP settings into helper functions to restore functionality removed by commit 723b745 as identified by issue #4346
No change has been made to the logic of these settings - when SOCIAL_DEFAULT_ACCESS is enabled, users are added to the first space with the group specified by SOCIAL_DEFAULT_GROUP.
Further scope for enhancement would be to parse SOCIAL_DEFAULT_ACCESS as an integer (as indicated by the documentation) and use this as the space ID, rather than using Space.objects.first().
Another potential enhancement would be to check space membership on every login, and add the user to the configured space if they are not currently a member.